fix(ci): detect generated API missing #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Nov 2, 2023
| @@ -1,6 +1,6 @@ | |||
| // Code generated by protoc-gen-go-http. DO NOT EDIT. | |||
| // versions: | |||
| // - protoc-gen-go-http v2.7.0 | |||
There was a problem hiding this comment.
this is the result of generating the API bindings with the latest version of the tools
| go install ariga.io/atlas/cmd/atlas@v0.12.0 | ||
|
|
||
| # initialize API tooling | ||
| .PHONY: init-api-tools |
There was a problem hiding this comment.
I split the tools for API handling to its own target so the impact in the CI during installation is limited.
| go install github.com/bufbuild/buf/cmd/buf@v1.10.0 | ||
| go install github.com/envoyproxy/protoc-gen-validate@v1.0.1 | ||
| # Tools fixed to a specific version via its commit since they are not released standalone | ||
| go install github.com/go-kratos/kratos/cmd/protoc-gen-go-errors/v2@v2.0.0-20231102162905-3fc8fb7a0a0b |
There was a problem hiding this comment.
I also make sure to "fix the version" of some of these deps, before it was latest.
buccarel
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during #411, we realized that out CI was not checking if all the autogenerated files were checked in. Now we do a similar approach we do for both migrations and ent files.