Skip to content

Conversation

javirln
Copy link
Member

@javirln javirln commented Nov 8, 2023

This patch removes two empty properties exposed by the attestation API.

Fixes #417

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!!

Thanks for the contribution, it looks good to me! 🚀

@migmartri
Copy link
Member

@javirln, there seems to be an issue with your commit. You might need to update your GPG key with your personal email address too.

image

@javirln
Copy link
Member Author

javirln commented Nov 8, 2023

@javirln, there seems to be an issue with your commit. You might need to update your GPG key with your personal email address too.

image

Yes, I've just updated my signing key and it seems the email I had previously does not match with the new one. I'll fix it 👀

Signed-off-by: Javier Rodriguez <javi.role1@gmail.com>
Signed-off-by: Javier Rodriguez <javier.rodleo@gmail.com>
@javirln javirln force-pushed the fix/remove-empty-descriptions branch from 7b85402 to b0e862e Compare November 8, 2023 15:13
@migmartri migmartri merged commit e1b519f into chainloop-dev:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

describe wf run includes empty information
2 participants