Skip to content

Conversation

buccarel
Copy link
Contributor

@buccarel buccarel commented Nov 14, 2023

Issue:
#433 (comment)

Closes #433

Signed-off-by: Mattia Buccarella <m.buccarella@gmail.com>
@buccarel buccarel marked this pull request as ready for review November 14, 2023 16:21
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

switch t {
case schemaapi.CraftingSchema_Runner_GITHUB_ACTION:
return &runners.GitHubAction{}
return runners.NewGithubAction()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you for making this change!

@buccarel buccarel merged commit d8662de into chainloop-dev:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circle CI runner type support
2 participants