Skip to content

Conversation

migmartri
Copy link
Member

digest alg can be different than sha256, i.e sha1 for a commit.

This removes a check we have in the API, ideally, we should run some validation that includes the sha1 format too.

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Copy link
Contributor

@buccarel buccarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@migmartri migmartri merged commit 794d16b into chainloop-dev:main Nov 26, 2023
@migmartri migmartri deleted the remove-sha56 branch November 26, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants