feat(controlplane): leave organization #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
buccarel
reviewed
Dec 4, 2023
| } | ||
|
|
||
| if len(membershipsInOrg) == 0 { | ||
| // Delete the org |
There was a problem hiding this comment.
Just an architectural question, to make sure I understand everything well.
What happens if, in between the membership deletion and the org deletion, some other membership is created? Where are these races being handled?
There was a problem hiding this comment.
Good question; they are not handled. I thought about this one, and to solve it, we'll need to move most of this logic to the data layer, where we could leverage ent transactions.
I just thought that the possibility of this race was very, very low and not worth the implementation in this first pass. That said, I'll create an issue for it so we don't forget.
buccarel
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to leave an organization
closes #414