Skip to content

chore: simplify membership check #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2023
Merged

chore: simplify membership check #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions app/controlplane/internal/biz/orginvitation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,26 +87,14 @@ func (uc *OrgInvitationUseCase) Create(ctx context.Context, orgID, senderID, rec
}

// 3 - Check if the user has permissions to invite to the org
memberships, err := uc.mRepo.FindByUser(ctx, senderUUID)
if err != nil {
return nil, fmt.Errorf("error finding memberships for user %s: %w", senderUUID.String(), err)
}

var hasPermission bool
for _, m := range memberships {
if m.OrganizationID == orgUUID {
// User has permission to invite to this org
hasPermission = true
break
}
}

if !hasPermission {
if membership, err := uc.mRepo.FindByOrgAndUser(ctx, orgUUID, senderUUID); err != nil {
return nil, fmt.Errorf("failed to find memberships: %w", err)
} else if membership == nil {
return nil, NewErrNotFound("user does not have permission to invite to this org")
}

// 4 - The receiver does not exist in the org already
memberships, err = uc.mRepo.FindByOrg(ctx, orgUUID)
memberships, err := uc.mRepo.FindByOrg(ctx, orgUUID)
if err != nil {
return nil, fmt.Errorf("error finding memberships for user %s: %w", senderUUID.String(), err)
}
Expand Down