feat: CAS readiness probe support #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Mar 24, 2023
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Mar 24, 2023
| jwtMiddleware.WithClaims(func() jwt.Claims { return &casJWT.Claims{} })), | ||
| // below you can see a re-implementation of the middleware as a stream interceptor | ||
| // If we require a logged in user we | ||
| selector.Server( |
There was a problem hiding this comment.
allow status endpoint without authentication
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Control plane readiness probe API endpoint to take into account that the CAS configuration is correct and can in fact reach the CAS gRPC API server.
In other words, now it checks that it can reach the
statuszendpoint of the configured CAS dependency.Refs #2