Skip to content

feat: improve upstream URL support #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023
Merged

feat: improve upstream URL support #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 99 additions & 83 deletions app/controlplane/internal/conf/conf.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions app/controlplane/internal/conf/conf.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions app/controlplane/internal/conf/conf.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,13 @@ message Server {
message HTTP {
string network = 1;
string addr = 2;
// External Address that will be exposed to the client
// Hostname for the HTTP server to get redirected (deprecated)
// Optional
string external_addr = 3;
google.protobuf.Duration timeout = 4;
string external_addr = 3 [deprecated = true];
// In the form of [scheme]://[host] i.e https://instance.chainloop.dev
// Optional
string external_url = 4 [(validate.rules).string.uri = true];
google.protobuf.Duration timeout = 5;
}

message GRPC {
Expand Down
Loading