Skip to content

chore(controlplane): remove authURL deprecated code #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023
Merged

chore(controlplane): remove authURL deprecated code #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa183fe
chore(controlplane): remove authURL deprecated code
migmartri Apr 20, 2023
6d30a78
chore: fix validation making it more strict
migmartri Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controlplane/configs/config.devel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
server:
http:
addr: 0.0.0.0:8000
external_addr: localhost:8000
timeout: 1s
http_metrics:
addr: 0.0.0.0:5000
Expand Down
176 changes: 80 additions & 96 deletions app/controlplane/internal/conf/conf.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 1 addition & 22 deletions app/controlplane/internal/conf/conf.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions app/controlplane/internal/conf/conf.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,9 @@ message Server {
message HTTP {
string network = 1;
string addr = 2;
// Hostname for the HTTP server to get redirected (deprecated)
// Optional
string external_addr = 3 [deprecated = true];
// In the form of [scheme]://[host] i.e https://instance.chainloop.dev
// Optional
string external_url = 4 [(validate.rules).string.uri = true];
string external_url = 4;
google.protobuf.Duration timeout = 5;
}

Expand Down
Loading