Handle failure to reserve pre-reserved section when initializing server thread context. OS#15209418 #5536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on jit server init time. OS#15209418
chakrabot
pushed a commit
that referenced
this pull request
Jul 26, 2018
…when initializing server thread context. OS#15209418 Merge pull request #5536 from rajatd:prereserved If we failed to reserve memory for the pre-reserved section when initializing the jit server thread context, when the jit process does the reservation, the client process has no way of knowing the start address of the pre-reserved section. Instead, don't try to allocate memory for jitted code in pre-reserved section if we couldn't reserve when initializing server thread context
chakrabot
pushed a commit
that referenced
this pull request
Jul 26, 2018
…erved section when initializing server thread context. OS#15209418 Merge pull request #5536 from rajatd:prereserved If we failed to reserve memory for the pre-reserved section when initializing the jit server thread context, when the jit process does the reservation, the client process has no way of knowing the start address of the pre-reserved section. Instead, don't try to allocate memory for jitted code in pre-reserved section if we couldn't reserve when initializing server thread context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we failed to reserve memory for the pre-reserved section when initializing the jit server thread context, when the jit process does the reservation, the client process has no way of knowing the start address of the pre-reserved section.
Instead, don't try to allocate memory for jitted code in pre-reserved section if we couldn't reserve when initializing server thread context