Skip to content

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

$return .= $moveIcon;
$return .= ' </a>';
$return .= Display::getMdiIcon('poll', 'ch-tool-icon', null, 16, get_lang('Survey'));
$return .= '<a class="moved link_with_id" data-id="'.$survey['iid'].'" data_type="'.TOOL_SURVEY.'" title="'.$surveyTitle.'" href="'.api_get_self().'?'.api_get_cidreq().'&action=add_item&type='.TOOL_SURVEY.'&survey_id='.$survey['iid'].'&lp_id='.$this->lp_id.'" style="vertical-align:middle">'.$surveyTitle.'</a>';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable "lp_id" is not in valid camel caps format

* @assert ('') === false
*/
public static function get_surveys($course_code, $session_id = 0)
public static function get_surveys($courseCode, int $sessionId = 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name "SurveyManager::get_surveys" is not in camel caps format

* @version January 2007
*/
public static function modify_filter($survey_id, $drh = false)
public static function modify_filter($survey_id, $url_params, $row)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name "SurveyUtil::modify_filter" is not in camel caps format

* @version January 2007
*/
public static function modify_filter($survey_id, $drh = false)
public static function modify_filter($survey_id, $url_params, $row)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable "survey_id" is not in valid camel caps format

* @version January 2007
*/
public static function modify_filter($survey_id, $drh = false)
public static function modify_filter($survey_id, $url_params, $row)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable "url_params" is not in valid camel caps format

$isDrh = false
) {
int $from,
int $number_of_items,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable "number_of_items" is not in valid camel caps format

// Survey id
$array[10] = $surveyId;

private static function prepare_survey_array($survey, $efv, $mandatoryAllowed, $isDrh, $canEdit = true) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name "SurveyUtil::prepare_survey_array" is not in camel caps format

// Survey id
$array[10] = $surveyId;

private static function prepare_survey_array($survey, $efv, $mandatoryAllowed, $isDrh, $canEdit = true) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening brace should be on a new line

}

$array[7] = Display::url(
$survey->getAnswered(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-line function call not indented correctly; expected 12 spaces but found 16

}

$array[7] = Display::url(
$survey->getAnswered(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-line function call not indented correctly; expected 12 spaces but found 16

Copy link

Code Climate has analyzed commit 6e410c7 and detected 54 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 48
Bug Risk 2
Clarity 3
Complexity 1

View more on Code Climate.

@NicoDucou NicoDucou merged commit 117fecb into chamilo:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants