Add AlphaSpinner component
#2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4682f95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
+ Coverage 84.57% 84.61% +0.04%
==========================================
Files 134 135 +1
Lines 2878 2886 +8
Branches 860 871 +11
==========================================
+ Hits 2434 2442 +8
+ Misses 439 415 -24
- Partials 5 29 +24 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
yangwooseong
force-pushed
the
WEB-1411/spinner
branch
2 times, most recently
from
52ed1f8
to
3822b7b
Compare
sungik-choi
approved these changes
May 28, 2024
| } | ||
| } | ||
|
|
||
| .Spinner { |
Comment on lines
17
to
21
| it('should render as a div by default', () => { | ||
| const { getByTestId } = renderSpinner() | ||
| const renderedSpinner = getByTestId(SPINNER_TEST_ID) | ||
| expect(renderedSpinner.tagName).toBe('SPAN') | ||
| }) |
There was a problem hiding this comment.
테스트 이름과 수행하는 로직이 다릅니다.
Suggested change
| it('should render as a div by default', () => { | |
| const { getByTestId } = renderSpinner() | |
| const renderedSpinner = getByTestId(SPINNER_TEST_ID) | |
| expect(renderedSpinner.tagName).toBe('SPAN') | |
| }) | |
| it('should render as a span by default', () => { | |
| const { getByTestId } = renderSpinner() | |
| const renderedSpinner = getByTestId(SPINNER_TEST_ID) | |
| expect(renderedSpinner.tagName).toBe('SPAN') | |
| }) |
yangwooseong
force-pushed
the
WEB-1411/spinner
branch
from
3744d25
to
4682f95
Compare
yangwooseong
pushed a commit
that referenced
this pull request
May 29, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-react@2.0.7 ### Patch Changes - Change `position` property of `ToastContainer` to `fixed` ([#2245](#2245)) by @yangwooseong - Fix typo in `IconProps` jsdoc ([#2232](#2232)) by @yangwooseong - - Fix ReactJS console warnings. ([#2238](#2238)) by @nabi-chan - Introduce `useIsomorphicLayoutEffect` hook to use `useLayoutEffect` in SSR environment. - Add `AlphaSpinner` component ([#2237](#2237)) by @yangwooseong ## bezier-figma-plugin@0.5.7 ### Patch Changes - Updated dependencies - @channel.io/bezier-react@2.0.7 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
AlphaSpinner컴포넌트를 구현합니다.Details
Spinner컴포넌트와 다르게 곡선의 끝부분이 둥글게 디자인되어 있어서 border속성을 이용해서 구현하기가 어려웠습니다. 그래서circle엘리먼트를 2개 만들고 Indicator에 해당하는 곡선의 stroke-dasharray 속성을 조절하는 것으로 구현했습니다.AlphaSpinner를 사용해야 하는데, 버튼의 아이콘 크기에 맞게 크기를 조절을 해야합니다. 약간 고민이 필요해보여 후속 pr로 작업하겠습니다.Breaking change? (Yes/No)
References