Fix Toast moving up and down when window is scrolled #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: adc9bf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2245 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 134 134
Lines 2878 2878
Branches 869 860 -9
=======================================
Hits 2434 2434
- Misses 415 439 +24
+ Partials 29 5 -24 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
approved these changes
May 28, 2024
yangwooseong
pushed a commit
that referenced
this pull request
May 29, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-react@2.0.7 ### Patch Changes - Change `position` property of `ToastContainer` to `fixed` ([#2245](#2245)) by @yangwooseong - Fix typo in `IconProps` jsdoc ([#2232](#2232)) by @yangwooseong - - Fix ReactJS console warnings. ([#2238](#2238)) by @nabi-chan - Introduce `useIsomorphicLayoutEffect` hook to use `useLayoutEffect` in SSR environment. - Add `AlphaSpinner` component ([#2237](#2237)) by @yangwooseong ## bezier-figma-plugin@0.5.7 ### Patch Changes - Updated dependencies - @channel.io/bezier-react@2.0.7 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
2024-05-28.2.15.48.mov
(강제로 body의 height를 늘려서 스크롤했을 때 토스트가 이동하는 모습)
스크롤을 하면 토스트 위치가 바뀌는 버그가 있어서 이를 수정합니다.
Details
ToastProvider의 container를 스크롤하면ToastContainer의 위치가 바뀔 수 있어서 생긴 버그입니다.ToastContainer의 position 을 absolute가 아닌 fixed로 변경합니다.Breaking change? (Yes/No)
References