Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[BUG] Dimension values with quotes raise syntax errors #732

Closed
kartikay-bagla opened this issue Feb 16, 2022 · 0 comments · Fixed by #1005
Closed

[BUG] Dimension values with quotes raise syntax errors #732

kartikay-bagla opened this issue Feb 16, 2022 · 0 comments · Fixed by #1005
Assignees
@kartikay-bagla
Milestone
v0.9.0

Comments

@kartikay-bagla
Copy link
Contributor

Describe the bug

A dimension with double quotes in it raises a syntax error during subgroup querying.

Fix

Sanitize dimension value strings before querying.
@kartikay-bagla kartikay-bagla self-assigned this Feb 16, 2022
kartikay-bagla added a commit that referenced this issue Feb 16, 2022
@kartikay-bagla
fix: fixes #732
e7ba7c2
@Samyak2 Samyak2 linked a pull request Feb 16, 2022 that will close this issue
fix: fixes #732 #735
Closed
@Samyak2 Samyak2 modified the milestones: v0.5.0, v0.4.1, v0.4.2 Feb 16, 2022
@Samyak2 Samyak2 modified the milestones: v0.4.2, v0.5.0, v0.5.1 Mar 11, 2022
@kartikay-bagla kartikay-bagla modified the milestones: v0.5.1, v0.9.0 Jun 15, 2022
@kartikay-bagla kartikay-bagla mentioned this issue Jun 22, 2022
Merged
9 tasks
@kartikay-bagla kartikay-bagla linked a pull request Jun 22, 2022 that will close this issue
Fixes the bug where having strings with quotes in your data would break it #1005
Merged
9 tasks
@Samyak2 Samyak2 closed this as completed Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kartikay-bagla kartikay-bagla

Labels
None yet
Projects
None yet
Milestone
v0.9.0
2 participants
@kartikay-bagla @Samyak2