Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the bug where having strings with quotes in your data would break it #1005

Merged
merged 13 commits into from
Jun 27, 2022

Conversation

kartikay-bagla
Copy link
Contributor

@kartikay-bagla kartikay-bagla commented Jun 22, 2022

Fixes #732.

We replace query strings which use pandas' eval and instead use dictionaries with values and then filter the data. No API changes are made, so no FE changes required.

This change affects

  • RCA
  • Anomaly
  • Alerts (because it affects the final string stored in the Anomaly output)

Status

@kartikay-bagla kartikay-bagla added this to the v0.9.0 milestone Jun 22, 2022
@kartikay-bagla kartikay-bagla self-assigned this Jun 22, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jun 22, 2022

@netlify
Copy link

netlify bot commented Jun 22, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 1d60fcc
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62b983792d9fed000835aa53

@kartikay-bagla kartikay-bagla linked an issue Jun 22, 2022 that may be closed by this pull request
Amatullah and others added 6 commits June 27, 2022 12:15
Co-authored-by: Kartikay <kartikaybagla@gmail.com>
Co-authored-by: Kartikay <kartikaybagla@gmail.com>
also fixed the import error in alerts.

NOTE: alerts will not work at this commit. The necessary changes will be
done in #1000 and alerts will work once that is merged too.
@Samyak2 Samyak2 merged commit 126ae07 into develop Jun 27, 2022
@Samyak2 Samyak2 deleted the fix/quotes-fix branch June 27, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dimension values with quotes raise syntax errors
3 participants