api: export one module for a group of api #2824

YangKeao · 2022-01-25T05:22:31Z

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

The controller-tools (including controller-gen) cannot work on multiple go modules, which makes it impossible to generate CRD for multiple versions of API.

What's changed and how it works?

In this PR, I moved the go.mod and go.sum to the /api directory, and move the /api/webhook to /pkg/webhook. All related files have been modified.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot · 2022-01-25T05:22:32Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Andrewmatilde
iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

STRRL · 2022-01-26T12:49:11Z

Could you update the #2811?

And it seems there are lots of webhook-related (validation and default relates) codes left in /api, should we also move them out of /api? (or in the next PRs)

…odule

YangKeao · 2022-02-10T04:13:01Z

Could you update the #2811?

And it seems there are lots of webhook-related (validation and default relates) codes left in /api, should we also move them out of /api? (or in the next PRs)

It doesn't matter. We can leave the webhook-related codes there (and it will not block the development of multi-version API).

…odule

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

codecov · 2022-02-17T06:30:32Z

Codecov Report

Merging #2824 (f6ba4ac) into master (7994087) will decrease coverage by 3.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2824      +/-   ##
==========================================
- Coverage   40.33%   36.80%   -3.54%     
==========================================
  Files         149      111      -38     
  Lines       12236     9487    -2749     
==========================================
- Hits         4936     3492    -1444     
+ Misses       6909     5675    -1234     
+ Partials      391      320      -71

Impacted Files	Coverage Δ
cmd/chaos-builder/impl.go	`0.00% <ø> (ø)`
pkg/webhook/affected_namespaces.go	`100.00% <ø> (ø)`
pkg/webhook/inject.go	`0.00% <ø> (ø)`
pkg/webhook/validate_auth.go	`0.00% <ø> (ø)`
pkg/workflow/controllers/deadline_reconciler.go	`64.44% <0.00%> (-5.19%)`	⬇️
.../workflow/controllers/workflow_entry_reconciler.go	`48.14% <0.00%> (-4.77%)`	⬇️
api/v1alpha1/awschaos_webhook.go
api/v1alpha1/common_webhook.go
api/v1alpha1/gcpchaos_webhook.go
api/v1alpha1/httpchaos_webhook.go
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7994087...f6ba4ac. Read the comment docs.

Andrewmatilde

LGTM, I think this PR may bring a lot of merge conflicts.

iguoyr

LGTM

cwen0 · 2022-02-28T07:11:54Z

/merge

ti-chi-bot · 2022-02-28T07:11:56Z

This pull request has been accepted and is ready to merge.

Commit hash: c711237

cwen0 · 2022-02-28T07:54:44Z

/run-e2e-test

* move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update CHANGELOG.md Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Trigger verify action when helm chart is modified (#2937) Signed-off-by: SiyuChen <ryougi201@gmail.com> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(ui): pod phases should be first letter capitalized (#2915) * fix(ui): pod phases should be first letter capitalized Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unify label case Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * feat: OpenAPI to TypeScript API Client and Form Data (#2770) * feat: OpenAPI to TypeScript API Client and Forms Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: go (verify) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: reuse kubebuilder marks Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update according to RFC Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: prevent ui:form appearing in crds Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add missing actions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update lockfile Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: support PhysicalMachineChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: merge commands into codegen Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: ci Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement another ignore check Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update package info Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update README Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: gen HTTPChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove nested ignores Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove remaining markers Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(workflow): no more event after accomplished (#2911) Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * helm: add TTL configuration on value.yaml and update helm docs (#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix wrong comment on workflow Dashboard HTTP API (#2947) * fix wrong comment on workflow Dashboard HTTP API Signed-off-by: xiang <xiang13225080@163.com> * update swagger Signed-off-by: xiang <xiang13225080@163.com> * api: export one module for a group of api (#2824) * move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix: replaced localhost:5000 with ghcr.io as registry name (#2919) * fix: replaced localhost:5000 with ghcr.io as registry name when building images Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * refactor bpm: generate uid for each process; remove identifier lock; remove blockingBuffer (#2918) * support uuid Signed-off-by: xixi <i@hexilee.me> * chaosdaemon fits new bpm Signed-off-by: xixi <i@hexilee.me> * save chaosdaemon/server Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> * add some comments Signed-off-by: xixi <i@hexilee.me> * fix stress chaos Signed-off-by: xixi <i@hexilee.me> * deprecate stdio lock and blockingbuffer Signed-off-by: xixi <i@hexilee.me> * remove buffers in bpm Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * log: add customized logger for daemon and bpm (#2902) * add customized logger for daemon and bpm Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * extract the grpc metadata into the context Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in killIOChaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add logs Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in httpchaos server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the context comments for process builder Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use the logger in arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add auto compile github action (#2948) * add auto compile github action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify the name of action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove comment expression Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add comments validation Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * rename the zst file name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * auto detect buildenv and devenv Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add debug information Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add cache and debug artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify cache step name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use another docker buildx driver Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add download bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add some comments and help message Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update auto-generated code Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: imlonghao <git@imlonghao.com> Co-authored-by: CWen <cwenyin0@gmail.com> Co-authored-by: WangXiang <xiang13225080@163.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: xixi <i@hexilee.me>

* move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

move v1alpha1 module to api

7e4059a

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot requested a review from cwen0 January 25, 2022 05:22

ti-chi-bot added the size/M label Jan 25, 2022

iguoyr self-requested a review January 25, 2022 06:52

ti-chi-bot added the needs-rebase label Jan 28, 2022

Merge remote-tracking branch 'upstream/master' into remove-v1alpha1-m…

1a83882

…odule

ti-chi-bot removed the needs-rebase label Feb 10, 2022

YangKeao added 2 commits February 17, 2022 13:53

Merge remote-tracking branch 'upstream/master' into remove-v1alpha1-m…

e179d2e

…odule

make check

c711237

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao requested a review from a team February 22, 2022 06:11

Andrewmatilde approved these changes Feb 22, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Feb 22, 2022

iguoyr approved these changes Feb 22, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 22, 2022

ti-chi-bot added the status/can-merge label Feb 28, 2022

Merge branch 'master' into remove-v1alpha1-module

f6ba4ac

ti-chi-bot merged commit 057cc60 into chaos-mesh:master Feb 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: export one module for a group of api #2824

api: export one module for a group of api #2824

YangKeao commented Jan 25, 2022

ti-chi-bot commented Jan 25, 2022 •

edited

STRRL commented Jan 26, 2022 •

edited

YangKeao commented Feb 10, 2022

codecov bot commented Feb 17, 2022 •

edited

Andrewmatilde left a comment

iguoyr left a comment

cwen0 commented Feb 28, 2022

ti-chi-bot commented Feb 28, 2022

cwen0 commented Feb 28, 2022

api: export one module for a group of api #2824

api: export one module for a group of api #2824

Conversation

YangKeao commented Jan 25, 2022

What problem does this PR solve?

What's changed and how it works?

ti-chi-bot commented Jan 25, 2022 • edited

STRRL commented Jan 26, 2022 • edited

YangKeao commented Feb 10, 2022

codecov bot commented Feb 17, 2022 • edited

Codecov Report

Andrewmatilde left a comment

Choose a reason for hiding this comment

iguoyr left a comment

Choose a reason for hiding this comment

cwen0 commented Feb 28, 2022

ti-chi-bot commented Feb 28, 2022

cwen0 commented Feb 28, 2022

ti-chi-bot commented Jan 25, 2022 •

edited

STRRL commented Jan 26, 2022 •

edited

codecov bot commented Feb 17, 2022 •

edited