fix(workflow): no more event after accomplished #2911

imlonghao · 2022-02-17T17:37:00Z

Signed-off-by: imlonghao git@imlonghao.com

What problem does this PR solve?

close #2901

What's changed and how it works?

It checks whether this node is already accomplished before
emit new events.

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.1
- release-2.0

Checklist

Tests

Unit test
E2E test
No code
Manual test (add steps below)

I didn't test it yet, looks should work.

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

ti-chi-bot · 2022-02-17T17:37:02Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL
iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-02-18T02:28:55Z

Codecov Report

Merging #2911 (cc6cc85) into master (48e27e6) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
- Coverage   40.29%   40.25%   -0.05%     
==========================================
  Files         149      149              
  Lines       12230    12236       +6     
==========================================
- Hits         4928     4925       -3     
- Misses       6912     6922      +10     
+ Partials      390      389       -1

Impacted Files	Coverage Δ
...g/workflow/controllers/parallel_node_reconciler.go	`62.02% <0.00%> (+0.48%)`	⬆️
pkg/workflow/controllers/task_reconciler.go	`6.70% <0.00%> (+0.77%)`	⬆️
pkg/workflow/controllers/serial_node_reconciler.go	`61.13% <100.00%> (+1.97%)`	⬆️
.../workflow/controllers/workflow_entry_reconciler.go	`46.03% <100.00%> (ø)`
pkg/workflow/controllers/deadline_reconciler.go	`64.44% <0.00%> (-5.19%)`	⬇️
pkg/workflow/controllers/chaos_node_reconciler.go	`55.87% <0.00%> (-2.30%)`	⬇️
pkg/selector/generic/mode.go	`28.20% <0.00%> (+2.56%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e27e6...cc6cc85. Read the comment docs.

STRRL

LGTM!

Thanks for your contribution!

STRRL · 2022-02-18T08:43:41Z

Hi @imlonghao , could you append a line of description in the CHANGELOG.md? Thanks a lot!

Signed-off-by: imlonghao <git@imlonghao.com>

iguoyr

LGTM

STRRL · 2022-02-25T03:42:47Z

/merge

ti-chi-bot · 2022-02-25T03:42:49Z

This pull request has been accepted and is ready to merge.

Commit hash: c9500c4

ti-srebot · 2022-02-25T06:08:05Z

cherry pick to release-2.0 failed

ti-srebot · 2022-02-25T06:08:31Z

cherry pick to release-2.1 in PR #2944

Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update CHANGELOG.md Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Trigger verify action when helm chart is modified (#2937) Signed-off-by: SiyuChen <ryougi201@gmail.com> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(ui): pod phases should be first letter capitalized (#2915) * fix(ui): pod phases should be first letter capitalized Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unify label case Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * feat: OpenAPI to TypeScript API Client and Form Data (#2770) * feat: OpenAPI to TypeScript API Client and Forms Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: go (verify) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: reuse kubebuilder marks Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update according to RFC Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: prevent ui:form appearing in crds Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add missing actions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update lockfile Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: support PhysicalMachineChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: merge commands into codegen Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: ci Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement another ignore check Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update package info Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update README Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: gen HTTPChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove nested ignores Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove remaining markers Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(workflow): no more event after accomplished (#2911) Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * helm: add TTL configuration on value.yaml and update helm docs (#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix wrong comment on workflow Dashboard HTTP API (#2947) * fix wrong comment on workflow Dashboard HTTP API Signed-off-by: xiang <xiang13225080@163.com> * update swagger Signed-off-by: xiang <xiang13225080@163.com> * api: export one module for a group of api (#2824) * move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix: replaced localhost:5000 with ghcr.io as registry name (#2919) * fix: replaced localhost:5000 with ghcr.io as registry name when building images Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * refactor bpm: generate uid for each process; remove identifier lock; remove blockingBuffer (#2918) * support uuid Signed-off-by: xixi <i@hexilee.me> * chaosdaemon fits new bpm Signed-off-by: xixi <i@hexilee.me> * save chaosdaemon/server Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> * add some comments Signed-off-by: xixi <i@hexilee.me> * fix stress chaos Signed-off-by: xixi <i@hexilee.me> * deprecate stdio lock and blockingbuffer Signed-off-by: xixi <i@hexilee.me> * remove buffers in bpm Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * log: add customized logger for daemon and bpm (#2902) * add customized logger for daemon and bpm Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * extract the grpc metadata into the context Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in killIOChaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add logs Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in httpchaos server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the context comments for process builder Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use the logger in arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add auto compile github action (#2948) * add auto compile github action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify the name of action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove comment expression Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add comments validation Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * rename the zst file name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * auto detect buildenv and devenv Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add debug information Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add cache and debug artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify cache step name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use another docker buildx driver Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add download bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add some comments and help message Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update auto-generated code Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: imlonghao <git@imlonghao.com> Co-authored-by: CWen <cwenyin0@gmail.com> Co-authored-by: WangXiang <xiang13225080@163.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: xixi <i@hexilee.me>

Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot added contribution first-time-contributor labels Feb 17, 2022

ti-chi-bot requested review from Andrewmatilde and STRRL February 17, 2022 17:37

ti-chi-bot added the size/S label Feb 17, 2022

STRRL added type/bug-fix A bug needs to be fixed. component/workflow labels Feb 18, 2022

STRRL approved these changes Feb 18, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Feb 18, 2022

STRRL added needs-cherry-pick-release-2.0 needs-cherry-pick-release-2.1 labels Feb 18, 2022

fix(workflow): no more event after accomplished

c9500c4

Signed-off-by: imlonghao <git@imlonghao.com>

imlonghao force-pushed the issue/2901 branch from f773334 to c9500c4 Compare February 19, 2022 13:11

imlonghao requested a review from STRRL February 19, 2022 13:11

iguoyr approved these changes Feb 23, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 23, 2022

ti-chi-bot added the status/can-merge label Feb 25, 2022

ti-chi-bot added 4 commits February 25, 2022 11:42

Merge branch 'master' into issue/2901

ee31662

Merge branch 'master' into issue/2901

5e85a23

Merge branch 'master' into issue/2901

aabfbfe

Merge branch 'master' into issue/2901

cc6cc85

ti-chi-bot merged commit 8523568 into chaos-mesh:master Feb 25, 2022

ti-srebot mentioned this pull request Feb 25, 2022

fix(workflow): no more event after accomplished (#2911) #2944

Merged

9 tasks

imlonghao deleted the issue/2901 branch February 25, 2022 06:18

igcherkaev pushed a commit to igcherkaev/chaos-mesh that referenced this pull request Mar 1, 2022

fix(workflow): no more event after accomplished (chaos-mesh#2911)

50ac036

Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

afzal442 pushed a commit to afzal442/chaos-mesh that referenced this pull request Mar 19, 2022

fix(workflow): no more event after accomplished (chaos-mesh#2911)

bfc457f

Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workflow): no more event after accomplished #2911

fix(workflow): no more event after accomplished #2911

imlonghao commented Feb 17, 2022 •

edited by STRRL

ti-chi-bot commented Feb 17, 2022 •

edited

codecov bot commented Feb 18, 2022 •

edited

STRRL left a comment

STRRL commented Feb 18, 2022

iguoyr left a comment

STRRL commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

fix(workflow): no more event after accomplished #2911

fix(workflow): no more event after accomplished #2911

Conversation

imlonghao commented Feb 17, 2022 • edited by STRRL

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Feb 17, 2022 • edited

codecov bot commented Feb 18, 2022 • edited

Codecov Report

STRRL left a comment

Choose a reason for hiding this comment

STRRL commented Feb 18, 2022

iguoyr left a comment

Choose a reason for hiding this comment

STRRL commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

imlonghao commented Feb 17, 2022 •

edited by STRRL

ti-chi-bot commented Feb 17, 2022 •

edited

codecov bot commented Feb 18, 2022 •

edited