helm: add TTL configuration on value.yaml and update helm docs #2921

cwen0 · 2022-02-21T09:26:53Z

Signed-off-by: cwen0 cwenyin0@gmail.com

What problem does this PR solve?

Add TTL configuration on value.yaml and update helm docs

What's changed and how it works?

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.1
- release-2.0

Checklist

Tests

Unit test
E2E test
No code
Manual test (add steps below)

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: cwen0 <cwenyin0@gmail.com>

ti-chi-bot · 2022-02-21T09:26:54Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

fewdan
iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

fewdan · 2022-02-22T09:20:33Z

helm/chaos-mesh/README.md

@@ -87,6 +87,9 @@ The following tables list the configurable parameters of the Chaos Mesh chart an
 | `dashboard.env.LISTEN_PORT` | | `2333` |
 | `dashboard.env.DATABASE_DRIVER`| The db drive used for Chaos Dashboard, support db: sqlite3, mysql| `sqlite3` |
 | `dashboard.env.DATABASE_DATASOURCE`| The db dsn used for Chaos Dashboard | `/data/core.sqlite` |
+| `dashboard.env.CLEAN_SYNC_PERIOD`| Set the sync period to clean up archived data | `12h` |
+| `dashboard.env.TTL_EVENT`| Set TTL of archived event data | `168h` |
+| `dashboard.env.TTL_EXPERIMENT`| Set TTL of archived experiment data | `336` |


Should it be '336h' instead of '336'?

iguoyr · 2022-02-22T11:29:55Z

helm/chaos-mesh/values.yaml

+    # Set the sync period to clean up archived data
+    CLEAN_SYNC_PERIOD: 12h
+    # Set TTL of archived event data
+    TTL_EVENT: 168h


Could we use 7d and 14d instead? 168h and 336h is not intuitive 🤔

Yes, I will improve it in another single pr.

Signed-off-by: cwen0 <cwenyin0@gmail.com>

iguoyr · 2022-02-23T10:32:48Z

@cwen0 install.sh need to be updated.

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 · 2022-02-23T10:41:50Z

@cwen0 install.sh need to be updated.

Fixed! PTAL again, Thanks!

iguoyr

LGTM

cwen0 · 2022-02-24T13:47:44Z

@fewdan PTAL again! Thanks!

fewdan

LGTM

fewdan · 2022-02-25T07:15:48Z

/merge

ti-chi-bot · 2022-02-25T07:15:50Z

This pull request has been accepted and is ready to merge.

Commit hash: 205fc14

…-mesh#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update CHANGELOG.md Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Trigger verify action when helm chart is modified (#2937) Signed-off-by: SiyuChen <ryougi201@gmail.com> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(ui): pod phases should be first letter capitalized (#2915) * fix(ui): pod phases should be first letter capitalized Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unify label case Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * feat: OpenAPI to TypeScript API Client and Form Data (#2770) * feat: OpenAPI to TypeScript API Client and Forms Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: go (verify) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: reuse kubebuilder marks Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update according to RFC Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: prevent ui:form appearing in crds Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add missing actions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update lockfile Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: support PhysicalMachineChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: merge commands into codegen Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: ci Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement another ignore check Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update package info Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update README Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: gen HTTPChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove nested ignores Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove remaining markers Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(workflow): no more event after accomplished (#2911) Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * helm: add TTL configuration on value.yaml and update helm docs (#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix wrong comment on workflow Dashboard HTTP API (#2947) * fix wrong comment on workflow Dashboard HTTP API Signed-off-by: xiang <xiang13225080@163.com> * update swagger Signed-off-by: xiang <xiang13225080@163.com> * api: export one module for a group of api (#2824) * move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix: replaced localhost:5000 with ghcr.io as registry name (#2919) * fix: replaced localhost:5000 with ghcr.io as registry name when building images Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * refactor bpm: generate uid for each process; remove identifier lock; remove blockingBuffer (#2918) * support uuid Signed-off-by: xixi <i@hexilee.me> * chaosdaemon fits new bpm Signed-off-by: xixi <i@hexilee.me> * save chaosdaemon/server Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> * add some comments Signed-off-by: xixi <i@hexilee.me> * fix stress chaos Signed-off-by: xixi <i@hexilee.me> * deprecate stdio lock and blockingbuffer Signed-off-by: xixi <i@hexilee.me> * remove buffers in bpm Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * log: add customized logger for daemon and bpm (#2902) * add customized logger for daemon and bpm Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * extract the grpc metadata into the context Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in killIOChaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add logs Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in httpchaos server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the context comments for process builder Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use the logger in arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add auto compile github action (#2948) * add auto compile github action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify the name of action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove comment expression Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add comments validation Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * rename the zst file name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * auto detect buildenv and devenv Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add debug information Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add cache and debug artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify cache step name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use another docker buildx driver Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add download bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add some comments and help message Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update auto-generated code Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: imlonghao <git@imlonghao.com> Co-authored-by: CWen <cwenyin0@gmail.com> Co-authored-by: WangXiang <xiang13225080@163.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: xixi <i@hexilee.me>

…-mesh#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

cwen0 added 2 commits February 21, 2022 17:01

helm: update archived data's ttl

3db8ab2

Signed-off-by: cwen0 <cwenyin0@gmail.com>

update helm doc

ea56de4

Signed-off-by: cwen0 <cwenyin0@gmail.com>

ti-chi-bot requested review from Hexilee and WangXiangUSTC February 21, 2022 09:27

ti-chi-bot added the size/S label Feb 21, 2022

cwen0 changed the title ~~helm: update archived data's TTL~~ helm: add TTL configuration on value.yaml and update helm docs Feb 21, 2022

fewdan reviewed Feb 22, 2022

View reviewed changes

iguoyr reviewed Feb 22, 2022

View reviewed changes

fix comments

25cca56

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 requested review from iguoyr and fewdan February 23, 2022 10:11

fix comments

205fc14

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 added the component/helm label Feb 23, 2022

iguoyr approved these changes Feb 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Feb 24, 2022

iguoyr mentioned this pull request Feb 24, 2022

Github Action: need to trigger verify action when helm chart is modified #2934

Closed

fewdan approved these changes Feb 25, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 25, 2022

ti-chi-bot added the status/can-merge label Feb 25, 2022

Merge branch 'master' into update-helm

3cf28ab

ti-chi-bot merged commit 77df839 into chaos-mesh:master Feb 25, 2022

cwen0 deleted the update-helm branch February 25, 2022 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm: add TTL configuration on value.yaml and update helm docs #2921

helm: add TTL configuration on value.yaml and update helm docs #2921

cwen0 commented Feb 21, 2022

ti-chi-bot commented Feb 21, 2022 •

edited

fewdan Feb 22, 2022

cwen0 Feb 23, 2022

iguoyr Feb 22, 2022 •

edited

cwen0 Feb 23, 2022

iguoyr commented Feb 23, 2022

cwen0 commented Feb 23, 2022

iguoyr left a comment

cwen0 commented Feb 24, 2022

fewdan left a comment

fewdan commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

helm: add TTL configuration on value.yaml and update helm docs #2921

helm: add TTL configuration on value.yaml and update helm docs #2921

Conversation

cwen0 commented Feb 21, 2022

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Feb 21, 2022 • edited

fewdan Feb 22, 2022

Choose a reason for hiding this comment

cwen0 Feb 23, 2022

Choose a reason for hiding this comment

iguoyr Feb 22, 2022 • edited

Choose a reason for hiding this comment

cwen0 Feb 23, 2022

Choose a reason for hiding this comment

iguoyr commented Feb 23, 2022

cwen0 commented Feb 23, 2022

iguoyr left a comment

Choose a reason for hiding this comment

cwen0 commented Feb 24, 2022

fewdan left a comment

Choose a reason for hiding this comment

fewdan commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

ti-chi-bot commented Feb 21, 2022 •

edited

iguoyr Feb 22, 2022 •

edited