Fix/daemonset psp #3350

stephen-harris · 2022-06-10T13:37:02Z

What problem does this PR solve?

What's changed and how it works?

Relaxed the allowedHostPaths to allow the entire socket path directory to be mounted and to always allow /lib/modules to be mounted, as these are required by the chaos-daemon daemonset.

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.2
- release-2.1

Checklist

CHANGELOG

I have updated the CHANGELOG.md
I have labeled this PR with "no-need-update-changelog"

Tests

Unit test
E2E test
No code
Manual test (add steps below)

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

ti-chi-bot · 2022-06-10T13:37:03Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2022-06-10T13:37:10Z

Welcome @stephen-harris!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

STRRL · 2022-06-13T02:11:52Z

Welcome @stephen-harris ! Thanks for your contribution!

STRRL

LGTM!

STRRL · 2022-06-13T02:22:14Z

/cc @xlgao-zju @YangKeao

ti-chi-bot · 2022-06-13T02:22:16Z

@STRRL: GitHub didn't allow me to request PR reviews from the following users: xlgao-zju.

Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xlgao-zju @YangKeao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xlgao-zju · 2022-06-13T03:16:26Z

helm/chaos-mesh/templates/chaos-daemon-rbac.yaml

@@ -88,15 +88,15 @@ spec:
    - IPC_LOCK
  {{- end }}
  allowedHostPaths:
-    - pathPrefix: {{ .Values.chaosDaemon.socketPath }}
+    - pathPrefix: {{ .Values.chaosDaemon.socketPath | dir }}


it would be better if we set allowedHostPaths according to this block of code:

https://github.com/chaos-mesh/chaos-mesh/blob/master/helm/chaos-mesh/templates/chaos-daemon-daemonset.yaml#L187-L200

Hi @stephen-harris , please take a look ❤️

@xlgao-zju I've moved the logic to a helper and used it in both the daemonset and psp

Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

…os-mesh#3359) * add a comment to the flag size of memory size in the dashboard Signed-off-by: FingerLeader <wanxfinger@gmail.com> * update CHANGELOG.md Signed-off-by: FingerLeader <wanxfinger@gmail.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

* update api Signed-off-by: xiang <xiang13225080@163.com> * generate byteman rule file for mysql Signed-off-by: xiang <xiang13225080@163.com> * minor fix Signed-off-by: xiang <xiang13225080@163.com> * add integration test Signed-off-by: xiang <xiang13225080@163.com> * fix ci Signed-off-by: xiang <xiang13225080@163.com> * address comment Signed-off-by: xiang <xiang13225080@163.com> * update comment Signed-off-by: xiang <xiang13225080@163.com> Co-authored-by: Zhou Zhiqiang <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

* chore: artifact hub annotations Signed-off-by: STRRL <im@strrl.dev> * chore: append changelog Signed-off-by: STRRL <im@strrl.dev> * chore: also append maintainers and license Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

* removed global log from pkg/dashboard/store Signed-off-by: Daivik <daivikdave229@gmail.com> * Add logger to pkg/dashboard/store Signed-off-by: Daivik <daivikdave229@gmail.com> * chore: update changelog chaos-mesh#2880 Signed-off-by: Daivik <daivikdave229@gmail.com> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Signed-off-by: xianglingao <xianglingao@tencent.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

* renamed all occurances of chaos testing to chaos-mesh Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com> * added namespace refactore to changed section Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com> * rename namespace in hidden directories Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com> * chore: update snap file Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: STRRL <im@strrl.dev> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

* remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * fix changlog error Signed-off-by: nio <nioshield@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

ti-chi-bot · 2022-06-23T15:30:27Z

@stephen-harris: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stephen-harris · 2022-06-23T15:31:59Z

Going to re-open this PR since I've messed up the branch

stephen-harris · 2022-06-23T15:40:15Z

#3390

ti-chi-bot added contribution first-time-contributor labels Jun 10, 2022

ti-chi-bot requested review from Andrewmatilde and STRRL June 10, 2022 13:37

ti-chi-bot added the size/XS label Jun 10, 2022

stephen-harris added 3 commits June 10, 2022 14:39

Always allow daemonset to mount /lib/modules

daca047

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Allow daemonset to mount socket directory

22afc13

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Update changelog

bd68014

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

stephen-harris force-pushed the fix/daemonset-psp branch from e202294 to bd68014 Compare June 10, 2022 13:40

STRRL approved these changes Jun 13, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Jun 13, 2022

xlgao-zju reviewed Jun 13, 2022

View reviewed changes

ti-chi-bot added the needs-rebase label Jun 15, 2022

STRRL added needs-cherry-pick-release-2.2 and removed needs-rebase labels Jun 17, 2022

ti-chi-bot added needs-rebase size/M and removed needs-rebase size/XS labels Jun 17, 2022

YangKeao and others added 6 commits June 23, 2022 16:28

Promote "Xianglin Gao" to committer (chaos-mesh#3317)

aaa02b5

Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

ci: ignore microsoft within markdown link check (chaos-mesh#3363)

064b2ae

Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

chore: remove release note in pr template (chaos-mesh#3372)

ce593ab

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

DaivikDave and others added 5 commits June 23, 2022 16:29

remove duplicated code (chaos-mesh#3378)

429681b

Signed-off-by: xianglingao <xianglingao@tencent.com> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

Move socket path logic to helper

de1e494

Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>

stephen-harris force-pushed the fix/daemonset-psp branch from 7b666a8 to de1e494 Compare June 23, 2022 15:30

ti-chi-bot added needs-rebase size/XXL and removed size/M labels Jun 23, 2022

stephen-harris closed this Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/daemonset psp #3350

Fix/daemonset psp #3350

stephen-harris commented Jun 10, 2022 •

edited

ti-chi-bot commented Jun 10, 2022 •

edited

ti-chi-bot commented Jun 10, 2022

STRRL commented Jun 13, 2022

STRRL left a comment

STRRL commented Jun 13, 2022

ti-chi-bot commented Jun 13, 2022

xlgao-zju Jun 13, 2022

STRRL Jun 17, 2022

stephen-harris Jun 23, 2022

ti-chi-bot commented Jun 23, 2022

stephen-harris commented Jun 23, 2022

stephen-harris commented Jun 23, 2022

Fix/daemonset psp #3350

Fix/daemonset psp #3350

Conversation

stephen-harris commented Jun 10, 2022 • edited

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Jun 10, 2022 • edited

ti-chi-bot commented Jun 10, 2022

STRRL commented Jun 13, 2022

STRRL left a comment

Choose a reason for hiding this comment

STRRL commented Jun 13, 2022

ti-chi-bot commented Jun 13, 2022

xlgao-zju Jun 13, 2022

Choose a reason for hiding this comment

STRRL Jun 17, 2022

Choose a reason for hiding this comment

stephen-harris Jun 23, 2022

Choose a reason for hiding this comment

ti-chi-bot commented Jun 23, 2022

stephen-harris commented Jun 23, 2022

stephen-harris commented Jun 23, 2022

stephen-harris commented Jun 10, 2022 •

edited

ti-chi-bot commented Jun 10, 2022 •

edited