rfc: refine error handling #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
STRRL
reviewed
Oct 28, 2021
| `r.Recorder.Event` to send kubernetes event if needed. The `recorder.Failed` is | ||
| a simple representation of error event. | ||
|
|
||
| #### Inside a grpc function implementation |
There was a problem hiding this comment.
What should I do with "Inside chaos dashboard restful API server"? ❤️
There was a problem hiding this comment.
I think it's better to talk about errors in grpc in two chapter:
- build and return errors in grpc server-side
- resolve errors in grpc client-side
How do you think about it?
There was a problem hiding this comment.
What should I do with "Inside chaos dashboard restful API server"? ❤️
Done.
There was a problem hiding this comment.
I think it's better to talk about errors in grpc in two chapter:
* build and return errors in grpc server-side * resolve errors in grpc client-sideHow do you think about it?
The total RFC is organized as "How to handle an error" and "How an error is consumed finally". They are generally the same with your proposal.
51 tasks
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
cwen0
reviewed
Dec 27, 2021
cwen0
reviewed
Dec 27, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
4 tasks
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
rendered version