fix(textarea): fix data corruption after multi-line input #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when inserting multiple lines of input at once, the underlying Go data array was incorrectly shared in memory across multiple rows of the textarea. This was causing input corruption, where a user trying to modify one line would see their text added on the next line as well. This patch fixes it.
|
Thank you so much @knz, this is really appreciated ❤️ |
maaslalani
approved these changes
Feb 5, 2023
renovate bot
referenced
this pull request
in sheldonhull/az-pr
Jun 5, 2023
… to v0.16.1 (#18) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/charmbracelet/bubbles](https://togithub.com/charmbracelet/bubbles) | require | minor | `v0.15.0` -> `v0.16.1` | copilot:all --- ### Release Notes <details> <summary>charmbracelet/bubbles</summary> ### [`v0.16.1`](https://togithub.com/charmbracelet/bubbles/releases/tag/v0.16.1) [Compare Source](https://togithub.com/charmbracelet/bubbles/compare/v0.16.0...v0.16.1) ### File Picker Bubble 📁 🫧 This release introduces a brand new `filepicker` bubble, new features, and a tonne of bugfixes. Let us know what you think, ask questions, or just say hello in our [Discord](https://charm.sh/chat). <img src="https://vhs.charm.sh/vhs-yET2HNiJNEbyqaVfYuLnY.gif" width="600" alt="File picker example"> For a quick start on how to use this bubble, take a look at the [Example code](https://togithub.com/charmbracelet/bubbletea/tree/master/examples/file-picker/main.go). ##### Getting Started Create a new file picker and add it to your Bubble Tea model. ```go picker := filepicker.New() picker.CurrentDirectory, err = os.UserHomeDir() if err != nil { // ... } m := model{ picker: picker, // ... } ``` Initialize the file picker in your `Model`'s `Init` function. ```go func (m model) Init() tea.Cmd { return tea.Batch( m.picker.Init(), // ... ) } ``` Update the filepicker as any other bubble in the `Update` function. After the `picker.Update`, use the `DidSelectFile(msg tea.Msg)` function to perform an action when the user selects a valid file. You may allow only certain file types to be selected with the `AllowedTypes` property and allow directories to be selected with the `DirAllowed` property. To see the currently selected file/directory use the `Path` property. ```go var cmd tea.Cmd m.picker, cmd = m.picker.Update(msg) // Did the user select a file? if didSelect, path := m.picker.DidSelectFile(msg); didSelect { // Get the path of the selected file. return m, tea.Println("You selected: " + selectedPath) } return m, cmd ``` For the full example on how to use this bubble, take a look at the [Example code](https://togithub.com/charmbracelet/bubbletea/tree/master/examples/file-picker/main.go). #### New - Filepicker: new bubble by [@​maaslalani](https://togithub.com/maaslalani) in [https://github.com/charmbracelet/bubbles/pull/343](https://togithub.com/charmbracelet/bubbles/pull/343) - Textarea: max width/height configurable by [@​knz](https://togithub.com/knz) in [https://github.com/charmbracelet/bubbles/pull/370](https://togithub.com/charmbracelet/bubbles/pull/370) - Spinner: periods of ellipsis by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/bubbles/pull/375](https://togithub.com/charmbracelet/bubbles/pull/375) - List: infinite scrolling by [@​jon4hz](https://togithub.com/jon4hz) in [https://github.com/charmbracelet/bubbles/pull/316](https://togithub.com/charmbracelet/bubbles/pull/316) #### Fixed - app would crash if `deleteWordRight` was called at the end of line by [@​infastin](https://togithub.com/infastin) in [https://github.com/charmbracelet/bubbles/pull/313](https://togithub.com/charmbracelet/bubbles/pull/313) - support pastes that end with a newline character by [@​knz](https://togithub.com/knz) in [https://github.com/charmbracelet/bubbles/pull/314](https://togithub.com/charmbracelet/bubbles/pull/314) - data corruption after multi-line input by [@​knz](https://togithub.com/knz) in [https://github.com/charmbracelet/bubbles/pull/318](https://togithub.com/charmbracelet/bubbles/pull/318) - Remove unused `BackgroundStyle` in TextInput by [@​savannahostrowski](https://togithub.com/savannahostrowski) in [https://github.com/charmbracelet/bubbles/pull/341](https://togithub.com/charmbracelet/bubbles/pull/341) - add bounds checking to the `SelectedRow` by [@​MikaelFangel](https://togithub.com/MikaelFangel) in [https://github.com/charmbracelet/bubbles/pull/351](https://togithub.com/charmbracelet/bubbles/pull/351) - fix(progress): last gradient color off by one by [@​residualmind](https://togithub.com/residualmind) in [https://github.com/charmbracelet/bubbles/pull/338](https://togithub.com/charmbracelet/bubbles/pull/338) - deprecate `CursorStyle` in favour of `Cursor.Style` by [@​maaslalani](https://togithub.com/maaslalani) in [https://github.com/charmbracelet/bubbles/pull/365](https://togithub.com/charmbracelet/bubbles/pull/365) - Reset blink only when `CursorBlink` by [@​remiposo](https://togithub.com/remiposo) in [https://github.com/charmbracelet/bubbles/pull/378](https://togithub.com/charmbracelet/bubbles/pull/378) #### New Contributors - [@​infastin](https://togithub.com/infastin) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/313](https://togithub.com/charmbracelet/bubbles/pull/313) - [@​gzipChrist](https://togithub.com/gzipChrist) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/332](https://togithub.com/charmbracelet/bubbles/pull/332) - [@​savannahostrowski](https://togithub.com/savannahostrowski) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/341](https://togithub.com/charmbracelet/bubbles/pull/341) - [@​MikaelFangel](https://togithub.com/MikaelFangel) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/351](https://togithub.com/charmbracelet/bubbles/pull/351) - [@​stefanbildl](https://togithub.com/stefanbildl) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/339](https://togithub.com/charmbracelet/bubbles/pull/339) - [@​residualmind](https://togithub.com/residualmind) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/338](https://togithub.com/charmbracelet/bubbles/pull/338) - [@​bashbunni](https://togithub.com/bashbunni) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/359](https://togithub.com/charmbracelet/bubbles/pull/359) - [@​squrki](https://togithub.com/squrki) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/373](https://togithub.com/charmbracelet/bubbles/pull/373) - [@​remiposo](https://togithub.com/remiposo) made their first contribution in [https://github.com/charmbracelet/bubbles/pull/378](https://togithub.com/charmbracelet/bubbles/pull/378) **Full Changelog**: charmbracelet/bubbles@v0.15.0...v0.16.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg?1" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or on [Discord](https://charm.sh/chat). ### [`v0.16.0`](https://togithub.com/charmbracelet/bubbles/compare/v0.15.0...v0.16.0) [Compare Source](https://togithub.com/charmbracelet/bubbles/compare/v0.15.0...v0.16.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/sheldonhull/az-pr). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found using the unit test suite at https://github.com/knz/bubbline
Previously, when inserting multiple lines of input at once, the underlying Go data array was incorrectly shared in memory across multiple rows of the textarea. This was causing input corruption, where a user trying to modify one line would see their text added on the next line as well.
This patch fixes it.
cc @maaslalani