Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add debounce example #348

Merged
merged 6 commits into from
Aug 25, 2022
Merged

docs: add debounce example #348

merged 6 commits into from
Aug 25, 2022

Conversation

bashbunni
Copy link
Member

Changes:

@bashbunni bashbunni added the documentation Improvements or additions to documentation label Jun 17, 2022
@maaslalani
Copy link
Contributor

Let me know if there is a specific reason this is better as markdown though that I haven't considered but I think this should be a examples/debounce/main.go so that you can run / modify the example and so that if we ever need to update it we can ensure it still compiles. The "How it works" section is awesome and we can put that at the top of the go file as a comment.

@bashbunni
Copy link
Member Author

I agree! Can move it to a running example

@bashbunni
Copy link
Member Author

(moved to an example instead of docs)

@bashbunni
Copy link
Member Author

let me know if comments could be improved or anything!

}

func (m model) View() string {
return "To exit press any key, then wait for one second without pressing anything."
Copy link
Contributor

@maaslalani maaslalani Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the view maybe show the tag so that if someone runs this example they see something changing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@bashbunni
Copy link
Member Author

heh, forgot to rebase from master before pushing 😂

@meowgorithm
Copy link
Member

Thank you @bashbunni!

@meowgorithm meowgorithm merged commit bb241ce into master Aug 25, 2022
@meowgorithm meowgorithm deleted the debounce-example branch August 25, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants