Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix lint issues in examples and tutorials #759

Merged
merged 2 commits into from
Jun 9, 2023
Merged

docs: fix lint issues in examples and tutorials #759

merged 2 commits into from
Jun 9, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 8, 2023

fixed everything up 🙏

@caarlos0
docs: fix lint issues in examples and tutorials
898cfa2 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Jun 8, 2023
@caarlos0 caarlos0 self-assigned this Jun 8, 2023
@caarlos0
Copy link
Member Author

caarlos0 commented Jun 8, 2023

see also #724

@bashbunni bashbunni mentioned this pull request Jun 8, 2023
Merged
bashbunni
bashbunni reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran each of these examples locally and all seem to be working as expected. Thanks Carlos! This is a much needed clean up 🧹

Note: the simple test is failing for me on this PR

examples/simple/main_test.go Outdated Show resolved Hide resolved
@caarlos0 caarlos0 merged commit b80eb83 into master Jun 9, 2023
@caarlos0 caarlos0 deleted the lint2 branch June 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni left review comments

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @bashbunni