Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable pty emulation #7

Closed
wants to merge 1 commit into from
Closed

feat: disable pty emulation #7

wants to merge 1 commit into from

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Sep 21, 2023 •
edited
Loading

This adds the ability to disable the session's PTY emulation from translating NL to CRLN. This is needed when allocating PTYs and applying their terminal modes from the session PTY request.

Reference: gliderlabs#210

@aymanbagabas
feat: disable pty emulation
f0d7584 
This adds the ability to disable the session's PTY emulation from
translating NL to CRLN. This is needed when allocating PTYs and applying
their terminal modes from the session PTY request.
@aymanbagabas
Copy link
Member Author

Ideally, we want to disable the emulation completely and make it opt-in using NewPtyWriter/NewPtyReadWriter. We would need to allocate a Pty for each Pty request using something like pty or go-pty. If Pty allocation failed, we could fall back to this emulation hack.

@aymanbagabas aymanbagabas mentioned this pull request Nov 29, 2023
Merged
1 task
@caarlos0
Copy link
Member

is this still needed?

@aymanbagabas
Copy link
Member Author

is this still needed?

Nope

@caarlos0 caarlos0 deleted the pty branch January 30, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @caarlos0