feat: allocate real pty #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
ptysess
branch
from
1aa5d86
to
669b249
Compare
caarlos0
approved these changes
Dec 1, 2023
aymanbagabas
force-pushed
the
ptysess
branch
3 times, most recently
from
72503be
to
0c40f63
Compare
This adds a new PtyHandler to handle allocating PTYs and storing them in a platform specific field in `Pty`. This PR is backward-compatible, it defaults to EmulatePty handler that sets the `emulatePty` field in context and uses `PtyWriter` to preserve the current behavor.
caarlos0
reviewed
Jan 8, 2024
caarlos0
approved these changes
Jan 8, 2024
caarlos0
approved these changes
Jan 10, 2024
caarlos0
reviewed
Jan 10, 2024
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
aymanbagabas
commented
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new PtyHandler to handle allocating PTYs and storing them in
a platform specific field in
Pty. This PR is backward-compatible,it defaults to EmulatePty handler that sets the
emulatePtyfield incontext and uses
PtyWriterto preserve the current behavior.Supersedes #7
TODO: