Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with lineTension #6288

Merged
merged 2 commits into from
May 24, 2019
Merged

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 21, 2019

If the deprecated option tension is used for line datasets, it doesn't make effect during animation. This regression was introduced in #5999.

This PR fixes the regression as well as the default lineTension value for radar charts in doc.

Master: https://jsfiddle.net/nagix/Lngz3r60/
Screen Shot 2019-05-22 at 12 42 33 AM

This PR: https://jsfiddle.net/nagix/7j2rp0tk/
Screen Shot 2019-05-22 at 12 39 52 AM

benmccann
benmccann previously approved these changes May 21, 2019
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

kurkle
kurkle previously approved these changes May 21, 2019
etimberg
etimberg previously approved these changes May 21, 2019
@nagix nagix dismissed stale reviews from etimberg, kurkle, and benmccann via 2e23fd5 May 22, 2019 08:50
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think config while more concise is less clear. It's harder to understand now that it's only the dataset-level configuration. I'm not strongly against it though and would be fine to merge this if everyone else agrees

@simonbrunel simonbrunel added this to the Version 2.9 milestone May 24, 2019
@simonbrunel simonbrunel merged commit b02a3a8 into chartjs:master May 24, 2019
@nagix nagix deleted the issue-6288 branch May 24, 2019 07:35
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants