Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with lineTension #6288

Merged
merged 2 commits into from
May 24, 2019
Merged

Fix regression with lineTension #6288

merged 2 commits into from
May 24, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 21, 2019

If the deprecated option tension is used for line datasets, it doesn't make effect during animation. This regression was introduced in #5999.

This PR fixes the regression as well as the default lineTension value for radar charts in doc.

Master: https://jsfiddle.net/nagix/Lngz3r60/
Screen Shot 2019-05-22 at 12 42 33 AM

This PR: https://jsfiddle.net/nagix/7j2rp0tk/
Screen Shot 2019-05-22 at 12 39 52 AM

benmccann
benmccann previously approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

kurkle
kurkle previously approved these changes May 21, 2019
View reviewed changes
etimberg
etimberg previously approved these changes May 21, 2019
View reviewed changes
@nagix nagix dismissed stale reviews from etimberg, kurkle, and benmccann via 2e23fd5 May 22, 2019 08:50
benmccann
benmccann approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think config while more concise is less clear. It's harder to understand now that it's only the dataset-level configuration. I'm not strongly against it though and would be fine to merge this if everyone else agrees

@simonbrunel simonbrunel added this to the Version 2.9 milestone May 24, 2019
@simonbrunel simonbrunel merged commit b02a3a8 into chartjs:master May 24, 2019
@nagix nagix deleted the issue-6288 branch May 24, 2019 07:35
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @simonbrunel
Fix regression with lineTension (chartjs#6288)
5a68815
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
This was referenced Jun 6, 2021
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel left review comments

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@nagix @benmccann @simonbrunel @etimberg @kurkle