Skip to content

Conversation

xr0master
Copy link
Contributor

fix #7821

Also changed the type for data.labels, the value can be string, Date, etc. Since not all types are known, set unknown by default.

@kurkle kurkle added the type: types Typescript type changes label Nov 4, 2020
@kurkle
Copy link
Member

kurkle commented Nov 4, 2020

To me it looks like stack option is missing from IChartDataset, care to add that too?

As a side note, it looks like the documentation only mentions that for Bar, while it looks like its available to all chart types (https://codepen.io/kurkle/pen/bGejbNE).

kurkle
kurkle previously approved these changes Nov 5, 2020
@xr0master
Copy link
Contributor Author

@kurkle I added stack to all dataset config.
I am not good at writing docs, but added dataset general config (Dataset Configuration) in the Data Structures

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can come up with a better structure to the docs still, but also think its another subject.

@etimberg etimberg merged commit afbe03c into chartjs:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0.0-beta3] incomplete IChartConfiguration
3 participants