add support for cursor based pagination #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #51957: [PHP] Add support for new pagination to client libs. |
kmossco
force-pushed
the
sc-51957/add_cursor_pagination
branch
3 times, most recently
from
fb605d8
to
df94345
Compare
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
kmossco
force-pushed
the
sc-51957/add_cursor_pagination
branch
from
df94345
to
69011c8
Compare
kmossco
commented
Sep 18, 2023
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
|
Code Climate has analyzed commit 42e3beb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.9%. View more on Code Climate. |
swember
approved these changes
Sep 19, 2023
daesu
approved these changes
Sep 27, 2023
|
Closing this for now, as the PR should now remove support for cursor pagination, and we have a ton of conflicts. Will open a new one very soon with the new logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the cursor based pagination that endpoints are now using as well as tests for the Plan endpoints that were missing.