support cursor based pagination #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #51957: [PHP] Add support for new pagination to client libs. |
Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
kmossco
force-pushed
the
sc-51957/support_cursor_pagination
branch
from
9ba3ed5
to
dadc365
Compare
|
Code Climate has analyzed commit dadc365 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 62.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.0%. View more on Code Climate. |
sbrych
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
We currently have another PR open that adds cursor pagination to the library but removes the old pagination as a breaking change. This adds the support for the new pagination in case there is a server regression and we end up with broken clients out there.