-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failing on macOS #27
Comments
Bumping CEF or downgrading to an older SDK are your two options. If after upgrading CEF to the latest it still provides that exact same log, assume you have to use an older SDK. That error is caused by Apple deprecating something CEF uses. If you're unfamiliar with how to use multiple versions of the SDK, the least intrusive way is to download Xcode 14.3 then before you run any commands, use |
Hi Chase,
I think you're right, Apple have been changing their SDKs.
They did recently update their default linker to something called 'ldprime'
so maybe that's part of the problem.
I don't know though, I have never tried building this project before.
Possibly it'd be enough just to ignore the warnings for now - I don't know
how you do that though.
By the way - just to share some enthusiasm - this project looks amazing and
I hope to use it to embed some browser-based functionality into some
terminal apps. At the moment I'm launching an external browser and it's a
bit clunky....
So I did try to upgrade CEF, but I didn't get far. For the record, this is
what I tried:
1. Updating the CEF version in CMakeLists.txt
```
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
-set(CEF_VERSION 113.1.4+g327635f+chromium-113.0.5672.63)
+set(CEF_VERSION 116.0.27+gd8c85ac+chromium-116.0.5845.190)
# TODO: fetch the checksum from the CDN itself
set(CEF_WIN_64_SHA 7717bbae3043ce99b761764e7754430b079dea7a)
set(CEF_LINUX_64_SHA fc51b4b80cdf961947b386407fe411a32cc043fa)
-set(CEF_MAC_ARM64_SHA a537fea97d388131a0718b3b4622b02260bcd9ae)
+set(CEF_MAC_ARM64_SHA 8f1f296da1ad24cebd4543e75a6175a9ad502884)
```
2. cmake complained about an unrecognised type char16 and recommended
char16_t, so I did this:
…--- a/awrit/input_event_handler.cc
+++ b/awrit/input_event_handler.cc
@@ -119,7 +119,7 @@ if(['textarea',
'input'].includes(document.activeElement.tagName.toLowerCase()))
- static const std::unordered_map<KeyboardCode::Type, char16>
windows_key_to_native_key {
+ static const std::unordered_map<KeyboardCode::Type, char16_t>
windows_key_to_native_key {
@@ -161,7 +161,7 @@ if(['textarea',
'input'].includes(document.activeElement.tagName.toLowerCase()))
- static const std::unordered_map<int, std::tuple<char16, int>>
key_to_code {
+ static const std::unordered_map<int, std::tuple<char16_t, int>>
key_to_code {
3. This is what it tells me.
I'm out of my depth at this point, so I'll leave it up to someone more
knowledgable:
```
[1/1] Linking CXX executable awrit/Release/awrit.app/Contents/MacOS/awrit
FAILED: awrit/Release/awrit.app/Contents/MacOS/awrit
&&
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-O3 -DNDEBUG -arch arm64 -isysroot .... [truncated]
ld: warning: ignoring duplicate libraries: 'awrit/string/libstring.a'
ninja: build stopped: subcommand failed.
```
Cheers
On Sun, 24 Sept 2023 at 09:29, Chase Colman ***@***.***> wrote:
Might have to bump the CEF version to the latest, seems like basically
Apple deprecated an API it uses. If that works, I'd appreciate a PR.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6XFLUG7U6W7WN66PNENLX35BBXANCNFSM6AAAAAA5DY5LEE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
same issue on M1 mac. perhaps for the meantime provide a release build that was built on an older platform if possible? |
I have an M2 with macOS 12, it builds fine. The SDK needs to be set to Xcode 14.3.1 with:
Not possible at the moment. You'll have to wait until Q1 2024.
|
Thank you for checking and the response. |
Thanks, I got it working using that method |
How did you guys do this? I tried downloading 14.3.1 from Apple Developer and set
|
From that log, it seems like you either did not install 14.3.1, did not rename it to Xcode14.3.1, or did not export immediately before the cmake commands.
|
You don't need to open it. You could try using |
It worked after xcode-select and clearing and rebuilding my build directory. Thank you for the assist. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Yes, it was written for Kitty. Wezterm is not supported by default, last I checked you have to enable Kitty image protocol support and Kitty keyboard escape protocol support: https://wezfurlong.org/wezterm/config/lua/config/enable_kitty_keyboard.html?h=kitty However that may break things in other software for Wezterm. I don't really have time to maintain this project for Wezterm, since it's not the terminal I use. If you do get it working using whatever image protocol and keyboard protocol is supported in Wezterm, feel free to contribute a PR. |
This is on a Silicon mac (Ventura 13.5.2).
Build dependencies as follows:
The Ninja command succeeded (
cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Release -S . -B build
).Then:
I tried upgrading CEF_VERSION in CMakeLists.txt and following my nose. It seemed to get a bit further but I soon gave up once there weren't any more helpful messages.
The text was updated successfully, but these errors were encountered: