Do not expose the hostname to the server, just make it localhost #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please test with the major email providers, that this does not result in any blocks? There are some references that if this hostname is incorrect, it can result in spam blockages. |
|
I'll do this but isn't the hostname just some random name the user or the vendor chose? |
It is not, it is supposed to be a dns name that resolves to the public IP of the sender, or the actual public IP. |
|
I tested with Gmail, Yahoo and Posteo now and all worked fine. Is this enough? |
Seems reasonable, if we run into issues we can change it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run the dc python remote tests on this and, no surprise, they ran fine.
Fix #25 fix chatmail/core#1728