fix: Only omit group changes messages if SELF is really added (#7220) #7229
Conversation
If a self-addition message is received, but we're already in the group, there must be no hidden member changes.
Old Delta Chat clients don't provide timestamps for added and removed members in messages, so at least implicit member changes may be ignored as it's not clear if they are newer than explicit member changes from modern clients. Lost messages aren't so frequent anyway, and overall compatibility with old versions may be limited already.
|
The fix is fine, but what is the reason for second commit ("feat: No implicit member changes from old Delta Chat clients")? If members are added or removed I expect that this does not happen silently even if the message does not have a timestamp. |
With the second commit this won't happen at all. If we are already in the group and receive a self-addition message from old Delta Chat, we can ignore all member changes because it's not clear whether they are fresher than member changes that we have. So we also don't add any "member added" messages to the chat. I think it's better to reduce support for old versions already, particularly in such corner cases. |
Fix #7220