Skip to content

feat: add new strings to ffi #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

feat: add new strings to ffi #7271

merged 1 commit into from
Oct 3, 2025

Conversation

r10s
Copy link
Contributor

@r10s r10s commented Oct 3, 2025

this was forgotten in #7266

ftr, the string 200 was in use in the past, i had a quick look, it seems totally unused now, so it seems fine to stay with that number for the new string

@r10s r10s requested a review from Hocuri October 3, 2025 12:58
Hocuri
Hocuri approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I had a nickle for every time I forgot to add some string to deltachat.h, I had around 4 nickles now. Which isn't much, but it's curious that it happened repeatedly 😂

Anyways, thanks for taking care!

@r10s r10s merged commit 8f2390a into main Oct 3, 2025
29 checks passed
@r10s r10s deleted the r10s/update-ffi-to-ch-strings branch October 3, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hocuri Hocuri Hocuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r10s @Hocuri