fix: is_configured(): Ensure that public key exists when returning true #7289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want configured accounts w/o a public key. The self-color depends on it.
iequidoo
force-pushed
the
iequidoo/configure-load_self_public_key
branch
from
1b0f222 to
e68b95d
Compare
iequidoo
changed the title
|
This is impossible to fix this way, we still want configured accounts w/o a keypair so that importing the own key, e.g. via ASM, works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want configured accounts w/o a public key. The self-color depends on it.
Found the bug while testing accounts creation in Desktop: w/o the fix the account color changes after an app restart. Probably a test is needed.