fix: highlight errors when updating devfile

[vitaliy-guliy]

What does this PR do?

• Improves generating the new devworkspace object from a devfile
• Improves updating the devworkpace object
• uses modal messages instead of notifications to avoid the long messages being truncated

What issues does this PR fix?

eclipse-che/che#23031

How to test this PR?

• using the editor image from this PR, create a workspace from any github repository that contains a devfile ( https://github.com/vitaliy-guliy/vscode-test-extension/tree/test-sh-terminal for instance )
• add the following environment variable to the container and restart the workpace from local devfile

      env:
        - name: test
          value: false

• remove the changes above, add the following command and event, restart the workspace from local devfile

commands:

  - id: test
    exec:
      component: dev
      workingDir: ${PROJECTS_ROOT}/che-code
      commandLine: |
        echo test

events:
  preStart:
    - test

Does this PR contain changes that override default upstream Code-OSS behavior?

• the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
• the corresponding items were added to the CHANGELOG.md file
• rules for automatic git rebase were added to the .rebase folder

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-390-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-390-dev-amd64

[github-actions]

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-390-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-390-dev-amd64

[vitaliy-guliy]

@etsauer could you take a quick look?

[azatsarynnyy]

I chose Open Devfile when this dialog appeared for the first time

Then, I changed nothing in the devfile and clicked Restart Workpace from Local Devfile again. It suggested me restarting the workspace:

I'm not sure if this is expected behavior.

[azatsarynnyy]

The dialog with the devfile validation details is shown as described:

👍

[vitaliy-guliy]

I chose Open Devfile when this dialog appeared for the first time
Then, I changed nothing in the devfile and clicked Restart Workpace from Local Devfile again. It suggested me restarting the workspace:
I'm not sure if this is expected behavior.

Yes, it is expected behavior. In case of errors you can open the devfile with Open Devfile.
It just open the file in the editor and does nothing else.

[devstudio-release]

Build 3.16 :: code_3.x/1445: Console, Changes, Git Data

[devstudio-release]

Build 3.16 :: sync-to-downstream_3.x/7303: Console, Changes, Git Data

[devstudio-release]

Build 3.16 :: get-sources-rhpkg-container-build_3.x/7282: Console, Changes, Git Data

[devstudio-release]

Build 3.16 :: get-sources-rhpkg-container-build_3.x/7282:

code : 3.x :: Failed in 62859078 : code-rhel8-3.16-14
FAILURE: ==> 62859078:DEFAULT:ppc64le.log: <==atomic_reactor.tasks.binary_container_build.BuildProcessError: Build failed (rc=125): Error: server probably quit: unexpected EOF; copied to quay

[etsauer]

@vitaliy-guliy hey was out when you asked me to take a look at this. I see you already got it merged, but I would like to know HOW I would go about testing this so I can be more helpful next time.

Is there an editor.yaml I would use to point to this?

[vitaliy-guliy]

@etsauer to test the changes provided by pull request you can create a workspace using pre-built che-code image
like I did on this screenshot

So no need to add or edit editor.yaml, it is enough to paste the editor image into the field before workspace creation.