Various small fixes #255
Merged
Various small fixes #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
requested review from
azatsarynnyy,
rhopp and
vparfonov
as code owners
l0rd
approved these changes
Aug 19, 2019
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
|
I'm merging this PR since other changes depend on that but Dear Reviewers feel free to comment after the merge and I will create another PR with fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It contains some minor fixes that are separate by self-describing commits.
Here I'm adding some context to some of them:
fix: fix formatting in ts files
It's a pretty weird thing when you modify a few lines in a file, use
Format documentfeature and some extra lines are modified as well with formatting fixes only.I performing formatting of code, and hopefully, if everyone won't merge unformatted code, then we won't get such situation anymore.
I tried to automate a process of formatting but failed because of the following issues
Incorrect (potentially) indentation of function arguments spanning multiple lines microsoft/TypeScript#11629
Weird formatting indentation vvakame/typescript-formatter#118
fix: Fixes checking if Che Server is available
isCheServerReadymethod requires che URL and at the same time checks if namespace already exists.And CheURL is supposed to be fetched with a dedicated method that requests resources from k8s/OS API, and it does not check che namespace exists.
I believe that namespace existence is moved in the right place in the fix.
What issues does this PR fix or reference?
I've found these issues during work on #77
And created a separate PR to make review easier.