refactor: Have load export a function
#1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to have this in the main class
We are calling the constructor, which will always retain the original root.
We maintain compatibility for now by exporting a sensible default.
Separates Cheerio and CheerioAPI as different concepts. We no longer have to fight the type system to allow us to call the constructor without `new`.
Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
fb55
changed the title
load export a function instead of the constructorload export a function
This was referenced Aug 31, 2024
This was referenced Sep 1, 2024
This was referenced Sep 8, 2024
This was referenced Sep 12, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes quite a few currently necessary hacks.
BREAKING CHANGES
Low potential for breakages:
_originalRootproperty. Some methods, such asappendTo, can now have their roots overwritten by passing therootproperty toCheerioAPI.defaultexport now has a surroundingDocument, without any contents.