Skip to content

Solve 20. Valid Parentheses (step 1, 2) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Solve 20. Valid Parentheses (step 1, 2) #10

wants to merge 2 commits into from

Conversation

cheeseNA
Copy link
Owner

nodchip
nodchip reviewed Mar 25, 2024
View reviewed changes
20. Valid Parentheses/step1.py
return False
if open_bracket_stack.pop() != close_to_open[char]:
return False
return len(open_bracket_stack) == 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return not open_bracket_stack でも良いかもしれません。

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど, ありがとうございます！
そちらの方がよりPythonicな気がしますね.

nodchip
nodchip approved these changes Mar 28, 2024
View reviewed changes
Copy link

@nodchip nodchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よいと思います。

@rihib rihib mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nodchip nodchip nodchip approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheeseNA @nodchip