Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control report with date range logic update #7491

Merged
merged 3 commits into from
Oct 19, 2022
Merged

control report with date range logic update #7491

merged 3 commits into from
Oct 19, 2022

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Oct 19, 2022 •
edited
Loading

Signed-off-by: Abdul-Az aazeez@progress.com
https://chefio.atlassian.net/browse/KINETICS-237

🔩 Description: What code changed, and why?

If date range filter is passed GetStatsSummaryControls will extract the data from control index else it will behave like old way.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

rebuild components/compliance-service

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2022-10-19 at 12 20 15 PM

Screenshot 2022-10-19 at 12 20 56 PM

Screenshot 2022-10-19 at 12 21 16 PM

@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited
Loading

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 99c5d30
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/634f8f2ec1e12300082bcdd4

@iamazzeez iamazzeez self-assigned this Oct 19, 2022
@iamazzeez @Dmaddu
logic fix
e6f4f28 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@Dmaddu
modifying the control summary
99c5d30 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu Dmaddu changed the base branch from enhanced_compliance_reporting to add_compliance_config October 19, 2022 05:46
@iamazzeez
error message fix
9fa0f3b 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@Dmaddu Dmaddu merged commit 85aa556 into add_compliance_config Oct 19, 2022
@Dmaddu Dmaddu deleted the abdul/control_report_fix branch October 19, 2022 07:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
25.3% 25.3% Duplication

Dmaddu added a commit that referenced this pull request Oct 19, 2022
@Dmaddu @YashviJain01 @iamazzeez
Making Enhanced Compliance Reporting configurable (#7477)
5209d0d 
* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Serving Enhanced Reporting APIs based on configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* adding upgrade time for upgrade process (#7490)

* adding upgrade time for upgrade process

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding the correct names

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* control report with date range logic update (#7491)

* logic fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

* modifying the control summary

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* error message fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Addressing review comments

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>
Dmaddu added a commit that referenced this pull request Oct 19, 2022
@Dmaddu @YashviJain01 @iamazzeez
Making Enhanced Compliance Reporting configurable (#7477)
863d7b9 
* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Serving Enhanced Reporting APIs based on configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* adding upgrade time for upgrade process (#7490)

* adding upgrade time for upgrade process

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding the correct names

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* control report with date range logic update (#7491)

* logic fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

* modifying the control summary

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* error message fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Addressing review comments

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>
kalroy added a commit that referenced this pull request Oct 20, 2022
@Dmaddu @YashviJain01
@iamazzeez @kalroy
Enhanced compliance reporting (#7498)
85bee6e 
* enhanced_compliance_reporting

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Making Enhanced Compliance Reporting configurable (#7477)

* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Serving Enhanced Reporting APIs based on configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* adding upgrade time for upgrade process (#7490)

* adding upgrade time for upgrade process

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding the correct names

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* control report with date range logic update (#7491)

* logic fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

* modifying the control summary

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* error message fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Addressing review comments

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>

* Adding smart logic for upgrade and ingestion in parallel (#7488)

* Adding Functions for upgrade with smart logic

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Refactoring

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Add upgrade status cli (#7480)

* Initial checkin

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Update columns

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Added command for migration status

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Use latest storage function

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Delete unused sql file

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Updated the unit tests

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Introduced constants for status messages

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Rebased

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: Kallol Roy <kallol.roy@progress.com>

* Added the configuration for control workers (#7496)

* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding config for control workers

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding proto files

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Resolving conflicts from base branch

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Fixing errors

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Pipeline fix for enhanced reporting (#7499)

* Fixing pipeline issues

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* pipeline fix

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Kallol Roy <karoy@progress.com>
Co-authored-by: Kallol Roy <kallol.roy@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashviJain01 YashviJain01 YashviJain01 approved these changes

@kalroy kalroy Awaiting requested review from kalroy

@Dmaddu Dmaddu Awaiting requested review from Dmaddu

@GorillaGigabytes GorillaGigabytes Awaiting requested review from GorillaGigabytes

@daveaugustus daveaugustus Awaiting requested review from daveaugustus

Assignees

@iamazzeez iamazzeez

Labels
acceptance: internal acceptance: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamazzeez @daveaugustus @YashviJain01 @kalroy @Dmaddu