Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the configuration for control workers #7496

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Added the configuration for control workers #7496

merged 7 commits into from
Oct 20, 2022

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Oct 19, 2022 •
edited
Loading

🔩 Description: What code changed, and why?

Added the configuration for control worker i.e. control_data_populators_count, it will ingest the data to control index with these number of threads.

⛓️ Related Resources

https://chefio.atlassian.net/jira/software/c/projects/STALWART/boards/361?modal=detail&selectedIssue=STALWART-244

👍 Definition of Done

Added the config and number of workers can be used with this config

👟 How to Build and Test the Change

rebuild components/compliance-service/
rebuild components/automate-gateway/
rebuild components/automate-cli/
rebuild components/automate-deployment/

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@YashviJain01 YashviJain01 requested a review from a team as a code owner October 19, 2022 14:15
@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited
Loading

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 93b9d6b
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6350d512d9eb860009b0edfe

@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Oct 19, 2022
@YashviJain01 YashviJain01 marked this pull request as draft October 19, 2022 14:16
@github-actions github-actions bot removed the documentation Anything related to the Automate docs. label Oct 19, 2022
@YashviJain01 YashviJain01 changed the title Yashvi/control worker config Added the configuration for control workers Oct 19, 2022
@YashviJain01 YashviJain01 marked this pull request as ready for review October 19, 2022 14:41
Dmaddu and others added 7 commits October 20, 2022 10:26
@Dmaddu
Making Enhanced Compliance Reporting configurable
7b51d5a 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
Adding delta upgrade logic
400415c 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
updating getStartDateFromEndDate based on enhanced_reporting configur…
ba0af40 
…ation

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Adding config for control workers
ea14362 
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
adding proto files
df42dc7 
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Resolving conflicts from base branch
db0010e 
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Fixing errors
93b9d6b 
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@Dmaddu Dmaddu merged commit c2a70f7 into enhanced_compliance_reporting Oct 20, 2022
@Dmaddu Dmaddu deleted the yashvi/control_worker_config branch October 20, 2022 05:04
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kalroy added a commit that referenced this pull request Oct 20, 2022
@Dmaddu @YashviJain01
@iamazzeez @kalroy
Enhanced compliance reporting (#7498)
85bee6e 
* enhanced_compliance_reporting

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Making Enhanced Compliance Reporting configurable (#7477)

* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Serving Enhanced Reporting APIs based on configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* adding upgrade time for upgrade process (#7490)

* adding upgrade time for upgrade process

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding the correct names

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* control report with date range logic update (#7491)

* logic fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

* modifying the control summary

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* error message fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Addressing review comments

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>

* Adding smart logic for upgrade and ingestion in parallel (#7488)

* Adding Functions for upgrade with smart logic

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Refactoring

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Add upgrade status cli (#7480)

* Initial checkin

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Update columns

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Added command for migration status

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Use latest storage function

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Delete unused sql file

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Updated the unit tests

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Introduced constants for status messages

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Rebased

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: Kallol Roy <kallol.roy@progress.com>

* Added the configuration for control workers (#7496)

* Making Enhanced Compliance Reporting configurable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding delta upgrade logic

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating getStartDateFromEndDate based on enhanced_reporting configuration

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding config for control workers

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* adding proto files

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Resolving conflicts from base branch

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Fixing errors

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* Pipeline fix for enhanced reporting (#7499)

* Fixing pipeline issues

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* pipeline fix

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Kallol Roy <karoy@progress.com>
Co-authored-by: Kallol Roy <kallol.roy@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmaddu Dmaddu Dmaddu approved these changes

@kalroy kalroy kalroy approved these changes

Assignees
No one assigned
Labels
acceptance: internal acceptance: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YashviJain01 @kalroy @Dmaddu