Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config property for custom certs #7513

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

vivekshankar1
Copy link
Collaborator

@vivekshankar1 vivekshankar1 commented Oct 31, 2022

Signed-off-by: Vivek Shankar vshankar@progress.com

🔩 Description: What code changed, and why?

⛓️ Related Resources

#7495
https://chefio.atlassian.net/browse/SHIELD-165
https://chefio.atlassian.net/browse/SHIELD-161
https://chefio.atlassian.net/browse/SHIELD-162
https://chefio.atlassian.net/browse/SHIELD-163

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Vivek Shankar <vshankar@progress.com>
@vivekshankar1 vivekshankar1 requested a review from a team as a code owner October 31, 2022 06:09
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Oct 31, 2022
@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit bdbdbcc
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/635f66a5f74ca80009ed7a1a
😎 Deploy Preview https://deploy-preview-7513--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vivekshankar1 vivekshankar1 merged commit dc3a188 into main Oct 31, 2022
@vivekshankar1 vivekshankar1 deleted the change_config_property_for_certs branch October 31, 2022 06:21
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
12.7% 12.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants