MADROX-416: Event feed date selection. #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agam Mathur <agmathur@progress.com>
agmathur
added
the
event feed
👷 Deploy Preview for chef-automate processing.
|
|
Kudos, SonarCloud Quality Gate passed!
|
arunjn-progress
approved these changes
Mar 10, 2023
daveaugustus
approved these changes
Mar 13, 2023
shanmugapriya-tr
added a commit
that referenced
this pull request
Mar 14, 2023
This reverts commit 2cbaf37.
kalroy
added a commit
that referenced
this pull request
Mar 15, 2023
* Draft changes - license command on bastion Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * MADROX-416: Changed to @angular/common DatePipe. (#7756) Signed-off-by: Agam Mathur <agmathur@progress.com> * Bump version to 4.5.79 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * backup doc fix (#7758) Signed-off-by: Sahiba3108 <sgoyal@progress.com> * ES Host and Port based on config Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Bump version to 4.5.80 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * update the bootstrap steps before restore (#7769) Signed-off-by: punitmundra <pmundra@progress.com> Co-authored-by: punitmundra <pmundra@progress.com> * Bump version to 4.5.81 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * Bump version to 4.5.82 by Chef Expeditor Obvious fix; these changes are the result of automation not creative thinking. * Adding file name flag in report commands Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Minor changes Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Changed description Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Draft changes - license command on bastion Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * ES Host and Port based on config Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Adding file name flag in report commands Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Minor changes Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Changed description Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * File name made non mandatory Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Revert "MADROX-416: Changed to @angular/common DatePipe. (#7756)" This reverts commit 2cbaf37. * Revert "Bump version to 4.5.79 by Chef Expeditor" This reverts commit c61e386. * Revert "backup doc fix (#7758)" This reverts commit 9e407a7. * Revert "Bump version to 4.5.80 by Chef Expeditor" This reverts commit fff604e. * Revert "update the bootstrap steps before restore (#7769)" This reverts commit 4c740e7. * Modified function call to get the OpenSearch URL Signed-off-by: Kallol Roy <kallol.roy@progress.com> * Apply suggestions from code review Co-authored-by: Kallol Roy <karoy@progress.com> * Review comments applied Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Creating yaml docs Signed-off-by: Yashvi Jain <yashvi.jain@progress.com> * Changes Signed-off-by: Yashvi Jain <yashvi.jain@progress.com> * Doc changes Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * added format for testing Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Test changes Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> * Changes for testings Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> --------- Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> Signed-off-by: Agam Mathur <agmathur@progress.com> Signed-off-by: Sahiba3108 <sgoyal@progress.com> Signed-off-by: punitmundra <pmundra@progress.com> Signed-off-by: Kallol Roy <kallol.roy@progress.com> Signed-off-by: Yashvi Jain <yashvi.jain@progress.com> Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> Co-authored-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com> Co-authored-by: Agam Mathur <108087313+agmathur@users.noreply.github.com> Co-authored-by: Chef Expeditor <chef-ci@chef.io> Co-authored-by: Sahiba3108 <108404805+Sahiba3108@users.noreply.github.com> Co-authored-by: punitmundra <39169378+punitmundra@users.noreply.github.com> Co-authored-by: punitmundra <pmundra@progress.com> Co-authored-by: Kallol Roy <kallol.roy@progress.com> Co-authored-by: Kallol Roy <karoy@progress.com> Co-authored-by: Yashvi Jain <yashvi.jain@progress.com> Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Agam Mathur agmathur@progress.com
🔩 Description: What code changed, and why?
Changed the pipe from our custom datetime pipe to @angular/common DatePipe. This resolved the bug that we were seeing where our custom filter was showing the previous day date as per the selected date format.
On debugging, I found that we were passing the current date as the end-date but our custom filter was showing the previous day date, due to which there was the mismatch between the label of the graph vs the actual log date. This bug was resolved when I used the Angular DatePipe and since, there is a difference between the format used by our custom pipe and Angular pipe, I changed the date format as well, so that the output format remains the same.
⛓️ Related Resources
https://chefio.atlassian.net/browse/MADROX-416
https://angular.io/api/common/DatePipe
👍 Definition of Done
The end date shown in the graph label should be same as the current date.
👟 How to Build and Test the Change
Run a EC2 instance having some event logs, checkout the branch and run below commands:
build components/automate-ui-devproxy
start_automate_ui_background
start_all_services
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
showing_correct_date.mov