Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup doc fix #7758

Merged
merged 1 commit into from
Mar 13, 2023
Merged

backup doc fix #7758

merged 1 commit into from
Mar 13, 2023

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Mar 2, 2023

🔩 Description: What code changed, and why?

After creating backup in s3, if user tries to create backup in filesystem, then backup was not creating in filesystem. So we fix the configurations.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@Sahiba3108 Sahiba3108 requested a review from a team as a code owner March 2, 2023 11:17
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 92120d4
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/640ef5a89c89780008ad7662
😎 Deploy Preview https://deploy-preview-7758--chef-automate.netlify.app/automate/backup
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Mar 2, 2023
@Sahiba3108 Sahiba3108 self-assigned this Mar 2, 2023
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit 9e407a7 into main Mar 13, 2023
@Dmaddu Dmaddu deleted the sahiba/backup-doc-fix branch March 13, 2023 11:29
shanmugapriya-tr added a commit that referenced this pull request Mar 14, 2023
kalroy added a commit that referenced this pull request Mar 15, 2023
* Draft changes - license command on bastion

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* MADROX-416: Changed to @angular/common DatePipe. (#7756)

Signed-off-by: Agam Mathur <agmathur@progress.com>

* Bump version to 4.5.79 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* backup doc fix (#7758)

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

* ES Host and Port based on config

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Bump version to 4.5.80 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* update the bootstrap steps before restore (#7769)

Signed-off-by: punitmundra <pmundra@progress.com>
Co-authored-by: punitmundra <pmundra@progress.com>

* Bump version to 4.5.81 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* Bump version to 4.5.82 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* Adding file name flag in report commands

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Minor changes

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Changed description

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Draft changes - license command on bastion

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* ES Host and Port based on config

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Adding file name flag in report commands

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Minor changes

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Changed description

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* File name made non mandatory

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Revert "MADROX-416: Changed to @angular/common DatePipe. (#7756)"

This reverts commit 2cbaf37.

* Revert "Bump version to 4.5.79 by Chef Expeditor"

This reverts commit c61e386.

* Revert "backup doc fix (#7758)"

This reverts commit 9e407a7.

* Revert "Bump version to 4.5.80 by Chef Expeditor"

This reverts commit fff604e.

* Revert "update the bootstrap steps before restore (#7769)"

This reverts commit 4c740e7.

* Modified function call to get the OpenSearch URL

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Apply suggestions from code review

Co-authored-by: Kallol Roy <karoy@progress.com>

* Review comments applied

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Creating yaml docs

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Changes

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Doc changes

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* added format for testing

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Test changes

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>

* Changes for testings

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

---------

Signed-off-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>
Signed-off-by: Agam Mathur <agmathur@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: shanmugapriya-tr <shanmugapriya.tiruchengoderamanathan@progress.com>
Co-authored-by: Agam Mathur <108087313+agmathur@users.noreply.github.com>
Co-authored-by: Chef Expeditor <chef-ci@chef.io>
Co-authored-by: Sahiba3108 <108404805+Sahiba3108@users.noreply.github.com>
Co-authored-by: punitmundra <39169378+punitmundra@users.noreply.github.com>
Co-authored-by: punitmundra <pmundra@progress.com>
Co-authored-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: Kallol Roy <karoy@progress.com>
Co-authored-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants