Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper support for passing --features #32

Open
bkchr opened this issue Oct 22, 2023 · 1 comment
Open

Proper support for passing --features #32

bkchr opened this issue Oct 22, 2023 · 1 comment

Comments

@bkchr
Copy link

bkchr commented Oct 22, 2023

This --default-features CLI flag is not really working or at least not for me. Also looking into the docker image it is still doing some kind of processing, which is weird. I just want to pass feature flags, srtool should not care at all what or why I'm doing this and just forward these features.
@ntn-x2
Copy link

ntn-x2 commented Apr 10, 2024

+1 from our side. It seems that we're not able to compile a WASM that has the try-runtime feature enabled.

@ntn-x2 ntn-x2 mentioned this issue Apr 10, 2024
Merged
ntn-x2 added a commit to KILTprotocol/kilt-node that referenced this issue Apr 12, 2024
@ntn-x2
fix: try-runtime support in CI (#623)
94aec57 
Fixes KILTprotocol/ticket#3300.

Currently srtool does not really support features
(chevdor/srtool-cli#32), so we need a
workaround until features are supported in srtool. Since this is what we
do anyway now, I decided to go with using the same build infrastructure
we use for tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkchr @ntn-x2