Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checkBopomofo() mis-typed by modifying 'ㄧ' into '一' #212

Closed
wants to merge 3 commits into from

Conversation

qas612820704
Copy link

@qas612820704 qas612820704 commented Apr 11, 2017

chewing-editor expects when I type

phrase = "你好"
bopomofo = "ㄋ一ˇ ㄏㄠˇ"

will check the bopomofo and turn into

phrase = "你好"
bopomofo = "ㄋㄧˇ(`U+3127`) ㄏㄠˇ"

By changing bopomofo-like character "一"(U+4E00) into "ㄧ"(U+3127).

But mis-typed the character take this feature down.

This commit fixes this.

@qas612820704
Copy link
Author

Also let will turn into .

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 338c91e on qas612820704:master into 1679266 on chewing:master.

@david50407
Copy link
Member

Hi, I fixed this issue on #210 and merged into master.
I'm going to close this PR now, if you have any question, you can re-open it. Thanks :)

@david50407 david50407 closed this Apr 11, 2017
@qas612820704
Copy link
Author

@david50407. That's OK! Thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants