Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[critical] Data loss when selecting BMS versions on main screen listbox; and this happens non-predictably #114

Closed
arithex opened this issue Oct 19, 2023 · 2 comments
Labels

Comments

@arithex
Copy link
Collaborator

arithex commented Oct 19, 2023

1- modify some bindings
2- go back to home "Launcher" screen
3- select another BMS version (purposeful or accidental)
4- restore selection to the previous version

Observed: none of our changes were saved
Expected: our changes are saved

Making this worse: depending on how the startup codepath goes (probing the registry and saved-prefs file for last selection).. the listbox may not have an initial selection at all -- when you go to actually save/exit or launch BMS, the selection-change event kicks in, and you lose all your recent changes.

@arithex
Copy link
Collaborator Author

arithex commented Oct 19, 2023

Note this is not a regression for U3.. AL 2.2-2.3 seems to suffer from this problem.

Pretty sure I've seen this happen, but was never able to repro because of the winding codepaths on startup...

@arithex
Copy link
Collaborator Author

arithex commented Oct 20, 2023

Fixed in #112

@arithex arithex closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant