-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for issues 111, 113, 114, 115 #112
Conversation
…s, and dataloss when switching BMS versions on the launcher main screen.
Sorry I left this PR and branch open, while investigating issues/113. Expanding this to cover 111, 113 and 114. Separate notes below.. |
The situation: because BMS only supports max 2 pov-hats.. but user might have any number of devices, each with up to 4 hats per HID/DirectInput spec.. AL support is limited to supporting the primary-hats on the flightstick and throttle device(s). That seems quite reasonable to me. Note, these may be hats on the same device.. and there may possibly not be a throttle axis/device at all (eg. for gamepad users, using buttons or the new xInput to control throttle) Testing done.. |
#114 I think there are still other codepaths which throw away unsaved work.. eg. plugging in new HID devices. But this one was especially critical, because there were unavoidable conditions that would trigger the bmsListbox.SelectionChanged event. |
…e launcher (without actually launching).
Adding fix for #115 - losing keyboard binding changes, when exiting the app (without actually launching). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be OK (honestly my head exploding for a lot of changes :P)
Rebase-merging to keep those big coarse-grained commits somewhat separated in the timeline. |
Solution: scrape the keyfile for header lines .. and populate the 'Category' dropdown list, accordingly.
This should work for any keyfile which adheres to that "1. First Section" convention.