Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues 111, 113, 114, 115 #112

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Fixes for issues 111, 113, 114, 115 #112

merged 4 commits into from
Oct 20, 2023

Conversation

arithex
Copy link
Collaborator

@arithex arithex commented Oct 18, 2023

Solution: scrape the keyfile for header lines .. and populate the 'Category' dropdown list, accordingly.

This should work for any keyfile which adheres to that "1. First Section" convention.

@arithex arithex requested a review from chihirobelmo October 18, 2023 22:39
…s, and dataloss when switching BMS versions on the launcher main screen.
@arithex arithex changed the title Bugfix for issue/111, category jumplist not working for F-15 keyfile Fixes for issues 111, 113, 114 Oct 19, 2023
@arithex arithex requested a review from chihirobelmo October 19, 2023 20:54
@arithex
Copy link
Collaborator Author

arithex commented Oct 19, 2023

Sorry I left this PR and branch open, while investigating issues/113. Expanding this to cover 111, 113 and 114. Separate notes below..

@arithex
Copy link
Collaborator Author

arithex commented Oct 19, 2023

#113

The situation: because BMS only supports max 2 pov-hats.. but user might have any number of devices, each with up to 4 hats per HID/DirectInput spec.. AL support is limited to supporting the primary-hats on the flightstick and throttle device(s). That seems quite reasonable to me.

Note, these may be hats on the same device.. and there may possibly not be a throttle axis/device at all (eg. for gamepad users, using buttons or the new xInput to control throttle)

Testing done..
[pass] 2 devices 2 hats - with stick first in DeviceSorting.txt order
[pass] 2 devices 2 hats - with throttle first in DeviceSorting.txt order
[pass] 2 devices w hats, but roll+throttle on primary (only 1 hat should work, in this situation)
[?] 1 device with roll+throttle, but 2 hats (is there even such a product?)
[pass] 1 device with roll+throttle, single hat
[pass] 1 device with roll, throttle=keyboard or xInput
[pass] 0 analog axes (eg. clean-install coldstart case)

@arithex
Copy link
Collaborator Author

arithex commented Oct 19, 2023

#114
Light refactor of AppReg startup flow, to ensure we always select an item in the listbox, and ofc always save work before selecting a different BMS location.

I think there are still other codepaths which throw away unsaved work.. eg. plugging in new HID devices. But this one was especially critical, because there were unavoidable conditions that would trigger the bmsListbox.SelectionChanged event.

@arithex arithex changed the title Fixes for issues 111, 113, 114 Fixes for issues 111, 113, 114, 115 Oct 20, 2023
@arithex
Copy link
Collaborator Author

arithex commented Oct 20, 2023

Adding fix for #115 - losing keyboard binding changes, when exiting the app (without actually launching).

@arithex
Copy link
Collaborator Author

arithex commented Oct 20, 2023

Copy link
Owner

@chihirobelmo chihirobelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be OK (honestly my head exploding for a lot of changes :P)

@arithex arithex merged commit fb1419a into develop Oct 20, 2023
@arithex
Copy link
Collaborator Author

arithex commented Oct 20, 2023

Rebase-merging to keep those big coarse-grained commits somewhat separated in the timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants