Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade mill to 0.11.0 #3367

Merged
merged 2 commits into from Jul 5, 2023
Merged

upgrade mill to 0.11.0 #3367

merged 2 commits into from Jul 5, 2023

Conversation

sequencer
Copy link
Member

This PR upgrade mill to 0.11.0, which is incompatible with older version, fixes lots of legacy design choice(e.g ammonite, overriding behavior).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer sequencer added the Internal Internal change, does not affect users, will be included in release notes label Jun 17, 2023
@sequencer sequencer force-pushed the mill0p11 branch 2 times, most recently from 517f2fb to 245000a Compare June 17, 2023 19:29
@sequencer sequencer added this to the 5.x milestone Jun 20, 2023
jackkoenig
jackkoenig approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jackkoenig jackkoenig merged commit 1f485a1 into main Jul 5, 2023
14 checks passed
@jackkoenig jackkoenig deleted the mill0p11 branch July 5, 2023 20:03
@mergify mergify bot added the Backported This PR has been backported label Jul 5, 2023
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@sequencer @mergify
Upgrade mill to 0.11.0 (#3367)
077220d 
Also add mill to CI.

(cherry picked from commit 1f485a1)

# Conflicts:
#	build.sc
@mergify mergify bot mentioned this pull request Jul 5, 2023
Merged
14 tasks
@sequencer sequencer mentioned this pull request Jul 31, 2023
Closed
mergify bot added a commit that referenced this pull request Nov 16, 2023
@mergify @sequencer @jackkoenig
upgrade mill to 0.11.0 (backport #3367) (#3407)
10ef4b9 
* Upgrade mill to 0.11.0 (#3367)

Also add mill to CI.

(cherry picked from commit 1f485a1)

# Conflicts:
#	build.sc

* Resolve backport conflicts

---------

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sequencer @jackkoenig