-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Chisel2 compatibility sanity checks. #340
Conversation
The first part looks like a direct transformation of the Chisel compatibility package. Is it useful, and what kind of bugs is it expected to catch? The Chisel2 RISC tester makes sense, but I don't think it's well targeted. What Chisel2 compatibility features in particular is it trying to test? Can we directly test those? I imagine individual tests that exercise the different connection semantics would be more useful, especially because a failure gives you a specific cause instead of "my omnibus processor test is on fire". |
Good point on the compatibility package transform. I'll pull it. |
The Chisel2 RISC tester is a "sanity" check, which is the issue this test is trying to address. Testing individual connection semantics is a good idea. I'll add some. |
Replace direct transformation of compatibility package eith more targeted (but still elaboration-only) tests.
@ucbjrl Can you check out why this is failing? |
It's because of src/main/scala/chisel3/compatibility.scala:273
Introduced by Simplify Enum API (#385) edb19a0, and CompatibilitySpec.scala:126
Should we update the test or the new (incompatible) requirement? |
I'd argue for changing the test. It makes no sense to specify a width in an enum since you can't control the values, and I don't think it was used outside chisel tests. |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
val value: Int = Gen.choose(0, Int.MaxValue).sample.get | ||
val l = UInt(value) | ||
l shouldBe a [UInt] | ||
l shouldBe 'lit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this line does, but it's awesome
Bumps [firrtl](https://github.com/freechipsproject/firrtl) from `580844e` to `d1dab1d`. - [Release notes](https://github.com/freechipsproject/firrtl/releases) - [Commits](chipsalliance/firrtl@580844e...d1dab1d) --- updated-dependencies: - dependency-name: firrtl dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.