Extend constants in probe.force and probe.forceInitial methods.
#3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Jul 12, 2023
jackkoenig
reviewed
Jul 12, 2023
jackkoenig
reviewed
Jul 12, 2023
jackkoenig
reviewed
Jul 12, 2023
| @@ -83,7 +93,7 @@ package object probe extends SourceInfoDoc { | |||
| /** Override existing driver of a writable probe. */ | |||
| def force(clock: Clock, cond: Bool, probe: Data, value: Data)(implicit sourceInfo: SourceInfo): Unit = { | |||
| requireHasWritableProbeTypeModifier(probe, "Cannot force a non-writable Probe.") | |||
| pushCommand(ProbeForce(sourceInfo, clock.ref, cond.ref, probe.ref, value.ref)) | |||
| pushCommand(ProbeForce(sourceInfo, clock.ref, cond.ref, probe.ref, padData(value, probe.width.get).ref)) | |||
There was a problem hiding this comment.
What happens if the width of a Probe itself is unknown?
There was a problem hiding this comment.
Repeating from the conversation on slack, firtool errors out if the probe width does not eventually compute to the force value width. So I have decided for now to just error if either of these widths are unknown, though for future purposes this may be too strict.
jackkoenig
reviewed
Jul 14, 2023
Comment on lines
81
to
82
| case Some(w) => | ||
| if (w > probeWidth) Builder.error(s"Data width $w is larger than $probeWidth.") |
There was a problem hiding this comment.
If probe width is unknown, but data width is known, there's an extra error being generated that is unnecessary. I think you should tweak this like so:
Suggested change
| case Some(w) => | |
| if (w > probeWidth) Builder.error(s"Data width $w is larger than $probeWidth.") | |
| case Some(w) => | |
| if (probe.widthOption.exists(w > _)) Builder.error(s"Data width $w is larger than $probeWidth.") |
jackkoenig
approved these changes
Jul 14, 2023
debs-sifive
added
the
Please Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Properly extend forced values in
probe.forceandprobe.forceInitialmethods. Error out on unknown widths.Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.